You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This StackOverflow answer explains differences between GNU and BSD/macOS sed. The current Makefile uses sed in a way that causes an error with BSD/macOS sed:
± make crds-to-chart
cp deploy/crds/*.yaml deploy/charts/secret-manager/templates/crds/; \
foriin deploy/charts/secret-manager/templates/crds/*.yaml;do \
sed -i '1s/.*/{{- if .Values.installCRDs }}/;$a{{- end }}'$i; \
done
sed: 1: "deploy/charts/secret-ma ...": extra characters at the end of d command
sed: 1: "deploy/charts/secret-ma ...": extra characters at the end of d command
sed: 1: "deploy/charts/secret-ma ...": extra characters at the end of d command
make: *** [crds-to-chart] Error 1
Expected behavior
Expect make targets to work across OSes.
Steps to reproduce the bug:
Run make crds-to-chart on macOS.
Workaround
macOS users can install GNU sed using brew install sed then following the instructions to setup $PATH to prefer GNU sed over macOS sed.
/kind bug
The text was updated successfully, but these errors were encountered:
I'm not sure there is a portable alternative for some sed commands. If this instance has an alternative which is portable then it could be updated. I would recommend macOS users switch to GNU sed.
Describe the bug:
This StackOverflow answer explains differences between GNU and BSD/macOS
sed
. The current Makefile usessed
in a way that causes an error with BSD/macOSsed
:Expected behavior
Expect make targets to work across OSes.
Steps to reproduce the bug:
Run
make crds-to-chart
on macOS.Workaround
macOS users can install GNU sed using
brew install sed
then following the instructions to setup$PATH
to prefer GNUsed
over macOSsed
./kind bug
The text was updated successfully, but these errors were encountered: