Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi artifact-type forwarding broken #223

Open
redcatbear opened this issue Jan 30, 2019 · 1 comment
Open

Multi artifact-type forwarding broken #223

redcatbear opened this issue Jan 30, 2019 · 1 comment
Labels

Comments

@redcatbear
Copy link
Collaborator

Description

When trying to forward a req artifact to an imp and a utest artifact from a Markdown file, the according implicit dsn artifact is not created.

If I forward to one type only, it works as expected.

Strangely there is a unit test that should cover this kind of situation. Looks like it does not completely:

https://github.com/itsallcode/openfasttrace/blob/develop/importer/markdown/src/test/java/org/itsallcode/openfasttrace/importer/markdown/TestMarkdownImporter.java

Steps to Reproduce

  1. Create requirement spec item req~boolean-operators~1 that needs dsn coverage
  2. Forward it throut dsn like this
    dsn --> impl, utest: req~boolean-operators~1
  3. Create coverage in impl and utest
  4. Run trace

Expected behavior

Trace is green

Environment

  • OFT: 2.2.0
  • OS: Fedora 29
  • Java Version: openjdk version "1.8.0_191"
    OpenJDK Runtime Environment (build 1.8.0_191-b13)
    OpenJDK 64-Bit Server VM (build 25.191-b13, mixed mode)
@redcatbear redcatbear added the bug label Jan 30, 2019
@redcatbear redcatbear self-assigned this Jan 30, 2019
@redcatbear redcatbear moved this from 📫 Backlog to ▶️ Ready to Start in OpenFastTrace Feb 11, 2024
@redcatbear redcatbear removed their assignment Feb 11, 2024
@kaklakariada
Copy link
Contributor

The problem is probably caused by the Markdown state machine. It recognizes FORWARD patterns only in states START and OUTSIDE. When adding a forwarding in the middle (see below) it won't detect the forwarding:

req~boolean-operators~1
Needs: dsn
dsn --> impl, utest: req~boolean-operators~1

A workaround would be to force the state machine into the OUTSIDE state by prefixing the forwarding line with a header and some text:

req~boolean-operators~1
Needs: dsn
# Separator
ignore
dsn --> impl, utest: req~boolean-operators~1

Fixing this will require updating the state machine to allow forwarding also in SPEC_ITEM state.

@kaklakariada kaklakariada removed this from the 3.8.0 Reporter Improvements milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ▶️ Ready to Start
Development

No branches or pull requests

2 participants