Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary Es after <expression> and mangling collisions between <expression> and <number> #164

Open
zygoloid opened this issue Apr 3, 2023 · 1 comment

Comments

@zygoloid
Copy link
Contributor

zygoloid commented Apr 3, 2023

We require <expression> to be self-delimiting, but also sometimes follow an <expression> with an unnecessary E. We should remove those. This happens here:

  • <exception-spec> = DO <expression> E
  • <decltype> ::= Dt <expression> E
  • <decltype> ::= DT <expression> E
  • <template-arg> ::= X <expression> E

And something similar happens here:

  • <array-type> ::= A <expression> _ <type>
  • <builtin-type> ::= DB <expression> _
  • <builtin-type> ::= DU <expression> _

These last three manglings are also broken for another reason: they collide with the corresponding manglings with the <expression> replaced by a <number>, where the mangling could also be for an <unresolved-name>. We could fix them by moving the _ to before the <expression>.

@zygoloid zygoloid changed the title unnecessary Es after \<expression> and mangling collisions between \<expression> and \<number> unnecessary Es after <expression> and mangling collisions between <expression> and <number> Apr 3, 2023
@zygoloid
Copy link
Contributor Author

zygoloid commented Apr 3, 2023

(This should be tagged as ABI v2. These are too common to change now, except for DB / DU.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant