Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creamce::site::name defaults to fqdn #4

Open
lflis opened this issue Sep 19, 2017 · 1 comment
Open

creamce::site::name defaults to fqdn #4

lflis opened this issue Sep 19, 2017 · 1 comment

Comments

@lflis
Copy link

lflis commented Sep 19, 2017

creamce::site::name defaults to fqdn when not set what may cause issues when going production.
When that happens site is visible in bdii but some tools (i.e for atlas) are not able to discover such cream endpoint properly and assign it to a site

Please consider printing out warning instead of setting default value
@pandreetto
Copy link
Member

Are you suggesting, in case of default, to stop the puppet execution or just to notify the warning and go ahead?
The site name is used in many places and I'm not sure an empty string could be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pandreetto @lflis