Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataObject interfaces and focus on pages #14

Open
stevie-mayhew opened this issue Feb 5, 2015 · 4 comments
Open

Remove DataObject interfaces and focus on pages #14

stevie-mayhew opened this issue Feb 5, 2015 · 4 comments

Comments

@stevie-mayhew
Copy link
Contributor

cc @wernerkrauss

I'm looking at removing the DataObject parts of this system completely as we don't tend to use them, and there are other options for this.

Thoughts?

@stevie-mayhew
Copy link
Contributor Author

cc @Olliepop

@wernerkrauss
Copy link
Collaborator

It should still be possible, to manage Dataobjects in the same ModelAdmin / CatalogueAdmin together with pages. E.g. if i want to manage Products (a page) and ProductCategories (Dataobjects) in a Modeladmin.

@stevie-mayhew
Copy link
Contributor Author

Fair point, for now I'll tolerate them. Would you be opposed to it being in its own repo which requires this one?

@wernerkrauss
Copy link
Collaborator

As https://github.com/Little-Giant/silverstripe-catalogmanager/blob/master/code/ModelAdmin/CatalogPageAdmin.php#L20 checks for existence of the extension on the managed DataObject or Page it should be possible to remove it as it degrades gracefully to ModelAdmin. Haven't used it myself in the last project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants