Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Set court session type to arraignment when subpoena created #17209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

unakb
Copy link
Member

@unakb unakb commented Dec 11, 2024

So that it can be displayed in more detail on in the case Table

Á dagskrá -> Þingfesting

What

Set court session type to arraignment when sending subpoenas

Why

Because that is the court session type being registered, and so we can display it correctly in the active case table

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced handling of court session types in the Subpoena component, ensuring the court session type is set to "Arraignment" during updates.
  • Bug Fixes

    • Streamlined logic for clearing indictment decisions based on arraignment scheduling, improving data accuracy during updates.

So that it can be displayed in more detail on in the case Table
@unakb unakb requested a review from a team as a code owner December 11, 2024 14:31
Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Walkthrough

The changes in this pull request focus on the Subpoena component within the Subpoena.tsx file. A new import for CourtSessionType has been added, and the handleNavigationTo function has been updated to include an additionalUpdates object. This object sets the courtSessionType to CourtSessionType.ARRAIGNMENT and conditionally clears certain fields based on the arraignment status. The updates are sent to the server using this new structure, streamlining the handling of court session types while the rendering logic remains unchanged.

Changes

File Path Change Summary
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx Added import for CourtSessionType, updated handleNavigationTo to use additionalUpdates for court session type and field clearing logic.

Possibly related PRs

Suggested labels

automerge

Suggested reviewers

  • oddsson

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (2)

85-102: Consider enforcing arraignment type through TypeScript

While the implementation correctly sets the court session type to arraignment, the comment "This should always be an arraignment type" suggests this business rule could be better enforced through TypeScript.

Consider creating a specific type for the updates:

type SubpoenaCourtUpdate = {
  courtSessionType: CourtSessionType.ARRAIGNMENT;
  indictmentDecision?: null;
  courtDate?: null;
  postponedIndefinitelyExplanation?: null;
  indictmentRulingDecision?: null;
  mergeCaseId?: null;
  force?: boolean;
};

91-101: Extract conditional logic into a separate function

The conditional clearing of fields when rescheduling after court has met would be more maintainable if extracted into a separate function.

Consider refactoring like this:

const getClearanceFields = (
  isArraignmentScheduled: boolean,
  hasIndictmentDecision: boolean,
) => {
  if (!isArraignmentScheduled || !hasIndictmentDecision) {
    return {};
  }
  
  return {
    indictmentDecision: null,
    courtDate: null,
    postponedIndefinitelyExplanation: null,
    indictmentRulingDecision: null,
    mergeCaseId: null,
    force: true,
  };
};

const additionalUpdates = [{
  courtSessionType: CourtSessionType.ARRAIGNMENT,
  ...getClearanceFields(isArraignmentScheduled, Boolean(workingCase.indictmentDecision)),
}];
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5c8c1b9 and db5a5c2.

📒 Files selected for processing (1)
  • apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (1)

8-8: LGTM: Clean type import

The import of CourtSessionType from the shared types package follows TypeScript best practices and maintains type safety across the application.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.76%. Comparing base (0423040) to head (db5a5c2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...src/routes/Court/Indictments/Subpoena/Subpoena.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17209      +/-   ##
==========================================
- Coverage   35.76%   35.76%   -0.01%     
==========================================
  Files        6931     6931              
  Lines      147959   147960       +1     
  Branches    42168    42168              
==========================================
  Hits        52923    52923              
- Misses      95036    95037       +1     
Flag Coverage Δ
air-discount-scheme-backend 48.20% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.33% <ø> (ø)
api-catalogue-services 75.81% <ø> (ø)
api-domains-air-discount-scheme 37.90% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.42% <ø> (ø)
api-domains-criminal-record 47.92% <ø> (ø)
api-domains-driving-license 44.81% <ø> (ø)
api-domains-education 31.22% <ø> (ø)
api-domains-health-insurance 35.33% <ø> (ø)
api-domains-mortgage-certificate 35.16% <ø> (ø)
api-domains-payment-schedule 42.04% <ø> (ø)
application-api-files 61.73% <ø> (ø)
application-core 76.01% <ø> (ø)
application-system-api 38.76% <ø> (+<0.01%) ⬆️
application-template-api-modules 27.81% <ø> (+0.01%) ⬆️
application-templates-accident-notification 28.93% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.78% <ø> (ø)
application-templates-driving-license 18.12% <ø> (ø)
application-templates-estate 13.79% <ø> (ø)
application-templates-example-payment 24.71% <ø> (ø)
application-templates-financial-aid 14.42% <ø> (ø)
application-templates-general-petition 23.13% <ø> (ø)
application-templates-inheritance-report 6.54% <ø> (ø)
application-templates-marriage-conditions 15.11% <ø> (ø)
application-templates-mortgage-certificate 43.56% <ø> (ø)
application-templates-parental-leave 29.95% <ø> (ø)
application-types 6.57% <ø> (ø)
application-ui-components 1.24% <ø> (ø)
application-ui-shell 22.43% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 31.52% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 28.35% <ø> (ø)
clients-driving-license 40.79% <ø> (ø)
clients-driving-license-book 43.83% <ø> (ø)
clients-financial-statements-inao 49.59% <ø> (ø)
clients-license-client 1.26% <ø> (ø)
clients-middlewares 72.89% <ø> (-0.25%) ⬇️
clients-regulations 42.87% <ø> (ø)
clients-rsk-company-registry 31.04% <ø> (ø)
clients-rsk-personal-tax-return 38.32% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.41% <ø> (ø)
cms 0.40% <ø> (ø)
cms-translations 38.75% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.20% <ø> (ø)
contentful-apps 4.72% <ø> (ø)
dokobit-signing 62.10% <ø> (ø)
email-service 60.07% <ø> (ø)
feature-flags 90.76% <ø> (ø)
file-storage 45.86% <ø> (ø)
financial-aid-backend 51.40% <ø> (ø)
financial-aid-shared 17.88% <ø> (ø)
icelandic-names-registry-backend 54.33% <ø> (ø)
infra-nest-server 48.06% <ø> (ø)
infra-tracing 69.63% <ø> (ø)
island-ui-core 30.92% <ø> (ø)
judicial-system-api 20.16% <ø> (ø)
judicial-system-audit-trail 68.94% <ø> (ø)
judicial-system-backend 55.88% <ø> (ø)
judicial-system-formatters 78.28% <ø> (ø)
judicial-system-message 66.47% <ø> (ø)
judicial-system-message-handler 48.23% <ø> (ø)
judicial-system-scheduler 70.97% <ø> (ø)
judicial-system-types 42.22% <ø> (ø)
judicial-system-web 27.89% <0.00%> (-0.01%) ⬇️
license-api 42.91% <ø> (ø)
localization 10.15% <ø> (ø)
logging 58.02% <ø> (ø)
message-queue 67.76% <ø> (ø)
nest-audit 65.78% <ø> (ø)
nest-aws 51.93% <ø> (ø)
nest-config 76.38% <ø> (ø)
nest-core 53.16% <ø> (ø)
nest-feature-flags 51.00% <ø> (ø)
nest-problem 45.64% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.13% <ø> (ø)
nova-sms 61.42% <ø> (ø)
portals-admin-regulations-admin 1.80% <ø> (ø)
portals-core 19.76% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.55% <ø> (ø)
services-auth-delegation-api 58.53% <ø> (ø)
services-auth-ids-api 52.53% <ø> (-0.01%) ⬇️
services-auth-public-api 49.40% <ø> (+<0.01%) ⬆️
services-sessions 65.35% <ø> (ø)
services-university-gateway 49.39% <ø> (-0.12%) ⬇️
services-user-notification 46.55% <ø> (-0.03%) ⬇️
services-user-profile 56.89% <ø> (-0.09%) ⬇️
shared-components 30.08% <ø> (ø)
shared-form-fields 33.88% <ø> (ø)
shared-mocking 58.64% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.31% <ø> (ø)
web 2.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/routes/Court/Indictments/Subpoena/Subpoena.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dce5d8...db5a5c2. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 914a9c6 🔗

98 Total Test Services: 0 Failed, 90 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.04%), 199 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 63 0 22.97s N/A Link
air-discount-scheme-web 0 0 0 2 0 7.69s N/A Link
api 0 0 0 4 0 3.18s N/A Link
api-catalogue-services 0 0 0 23 0 13.63s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 20.21s N/A Link
api-domains-assets 0 0 0 3 0 12.68s N/A Link
api-domains-auth-admin 0 0 0 18 0 13.66s N/A Link
api-domains-communications 0 0 0 5 0 33.29s N/A Link
api-domains-criminal-record 0 0 0 5 0 9.4s N/A Link
api-domains-driving-license 0 0 0 23 0 28.17s N/A Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • services-user-profile - jest 49.28% (-0.04%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant