chore(accident-notification): organize utils

[jonnigs]

What

Merge util files with related functions together, same for .spec. Update imports.

Why

The utils folder had an overwhelming amount of files and tests, in some cases two different files had identical functions and tests. Now similar functions are together in files of manageable sizes and the number of files is also more manageable.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 29.94924% with 138 lines in your changes missing coverage. Please review.

Project coverage is 35.12%. Comparing base (5c8c1b9) to head (af6dc60).

Files with missing lines	Patch %	Lines
...accident-notification/src/utils/occupationUtils.ts	22.58%	48 Missing ⚠️
...lates/accident-notification/src/utils/miscUtils.ts	31.25%	33 Missing ⚠️
...s/accident-notification/src/utils/accidentUtils.ts	40.90%	13 Missing ⚠️
...tification/src/lib/AccidentNotificationTemplate.ts	26.66%	11 Missing ⚠️
.../accident-notification/src/utils/reportingUtils.ts	37.50%	10 Missing ⚠️
...lates/accident-notification/src/utils/dateUtils.ts	12.50%	7 Missing ⚠️
...ionForSection/whoIsTheNotificationForMultiField.ts	0.00%	6 Missing ⚠️
...mationMultiField/applicantInformationMultiField.ts	0.00%	5 Missing ⚠️
.../src/forms/PrerequsitesForm/dataHandlingSection.ts	0.00%	1 Missing ⚠️
.../src/forms/PrerequsitesForm/externalDataSection.ts	0.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16547      +/-   ##
==========================================
- Coverage   35.76%   35.12%   -0.64%     
==========================================
  Files        6931     6951      +20     
  Lines      147959   153831    +5872     
  Branches    42168    44573    +2405     
==========================================
+ Hits        52922    54040    +1118     
- Misses      95037    99791    +4754     

Flag	Coverage Δ
air-discount-scheme-backend	48.20% <ø> (ø)
air-discount-scheme-web	0.00% <ø> (ø)
api	3.33% <ø> (ø)
api-catalogue-services	75.81% <ø> (ø)
api-domains-air-discount-scheme	37.90% <ø> (ø)
api-domains-assets	26.71% <ø> (ø)
api-domains-auth-admin	48.49% <ø> (ø)
api-domains-communications	39.42% <ø> (ø)
api-domains-criminal-record	47.92% <ø> (ø)
api-domains-driving-license	44.81% <ø> (ø)
api-domains-education	31.22% <ø> (ø)
api-domains-health-insurance	35.33% <ø> (ø)
api-domains-mortgage-certificate	35.16% <ø> (ø)
api-domains-payment-schedule	42.04% <ø> (ø)
application-api-files	61.73% <ø> (ø)
application-core	76.01% <ø> (ø)
application-system-api	38.71% <31.72%> (-0.05%)	⬇️
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	25.78% <0.00%> (ø)
application-templates-driving-license	18.12% <0.00%> (ø)
application-templates-estate	13.79% <ø> (ø)
application-templates-example-payment	24.71% <0.00%> (ø)
application-templates-financial-aid	14.42% <ø> (ø)
application-templates-general-petition	23.13% <ø> (ø)
application-templates-inheritance-report	6.54% <ø> (ø)
application-templates-marriage-conditions	15.11% <ø> (ø)
application-templates-mortgage-certificate	43.60% <0.00%> (+0.04%)	⬆️
application-templates-parental-leave	29.95% <ø> (ø)
application-types	6.57% <ø> (ø)
application-ui-components	1.24% <ø> (ø)
application-ui-shell	22.43% <ø> (ø)
auth-admin-web	2.43% <ø> (ø)
auth-nest-tools	31.52% <ø> (ø)
auth-shared	75.00% <ø> (ø)
clients-charge-fjs-v2	28.35% <ø> (ø)
clients-driving-license	40.79% <ø> (ø)
clients-driving-license-book	43.83% <ø> (ø)
clients-financial-statements-inao	49.59% <ø> (ø)
clients-license-client	1.26% <ø> (ø)
clients-middlewares	72.89% <ø> (ø)
clients-regulations	42.87% <ø> (ø)
clients-rsk-company-registry	31.04% <ø> (ø)
clients-rsk-personal-tax-return	38.32% <ø> (ø)
clients-smartsolutions	12.77% <ø> (ø)
clients-syslumenn	49.41% <ø> (ø)
clients-zendesk	50.46% <ø> (ø)
cms	0.40% <ø> (ø)
cms-translations	38.75% <ø> (ø)
content-search-index-manager	95.65% <ø> (ø)
content-search-toolkit	8.20% <ø> (ø)
contentful-apps	4.72% <ø> (ø)
dokobit-signing	62.10% <ø> (ø)
email-service	60.07% <ø> (ø)
feature-flags	90.76% <ø> (ø)
file-storage	45.86% <ø> (ø)
financial-aid-backend	51.40% <ø> (ø)
financial-aid-shared	17.88% <ø> (ø)
icelandic-names-registry-backend	54.33% <ø> (ø)
infra-nest-server	48.06% <ø> (ø)
infra-tracing	69.63% <ø> (ø)
island-ui-core	30.92% <ø> (ø)
judicial-system-api	20.16% <ø> (ø)
judicial-system-audit-trail	68.94% <ø> (ø)
judicial-system-backend	55.88% <ø> (ø)
judicial-system-formatters	78.28% <ø> (ø)
judicial-system-message	66.47% <ø> (ø)
judicial-system-message-handler	48.23% <ø> (ø)
judicial-system-scheduler	70.97% <ø> (ø)
judicial-system-types	42.22% <ø> (ø)
judicial-system-web	27.89% <ø> (ø)
license-api	42.91% <ø> (ø)
localization	10.15% <ø> (ø)
logging	58.02% <ø> (ø)
message-queue	67.05% <ø> (-0.71%)	⬇️
nest-audit	65.78% <ø> (ø)
nest-aws	51.93% <ø> (ø)
nest-config	76.38% <ø> (ø)
nest-core	53.16% <ø> (ø)
nest-feature-flags	51.00% <ø> (ø)
nest-problem	45.64% <ø> (ø)
nest-sequelize	94.44% <ø> (ø)
nest-swagger	51.13% <ø> (ø)
nova-sms	61.42% <ø> (ø)
portals-admin-regulations-admin	1.80% <ø> (ø)
portals-core	19.76% <ø> (ø)
regulations	16.78% <ø> (ø)
residence-history	85.00% <ø> (ø)
services-auth-admin-api	52.55% <ø> (ø)
services-auth-ids-api	52.51% <ø> (-0.01%)	⬇️
services-auth-public-api	49.40% <ø> (ø)
services-sessions	65.30% <ø> (ø)
services-university-gateway	49.53% <ø> (+0.11%)	⬆️
services-user-notification	46.58% <ø> (ø)
services-user-profile	56.98% <ø> (ø)
shared-components	30.08% <ø> (ø)
shared-form-fields	33.88% <ø> (ø)
shared-mocking	58.64% <ø> (ø)
shared-pii	92.85% <ø> (ø)
shared-problem	87.50% <ø> (ø)
shared-utils	27.69% <ø> (ø)
skilavottord-ws	24.31% <ø> (ø)
web	2.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/accident-notification/src/dataProviders/index.ts	100.00% <100.00%> (ø)
...fication/src/fields/AgreementDescription/index.tsx	0.00% <ø> (ø)
.../src/fields/ApplicationStatus/StatusStep/index.tsx	0.00% <ø> (ø)
...fields/ApplicationStatus/applicationStatusUtils.ts	0.00% <ø> (ø)
...otification/src/fields/ApplicationStatus/index.tsx	0.00% <ø> (ø)
...t-notification/src/fields/DateOfAccident/index.tsx	0.00% <ø> (ø)
...ification/src/fields/DescriptionWithLink/index.tsx	0.00% <ø> (ø)
...notification/src/fields/FormOverview/ValueLine.tsx	0.00% <ø> (ø)
...ent-notification/src/fields/FormOverview/index.tsx	0.00% <ø> (ø)
.../fields/FormOverviewInReview/ConfirmationModal.tsx	0.00% <ø> (ø)
... and 46 more

... and 219 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8c1b9...af6dc60. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 28c1d31 🔗

✅ 96 Total Test Services: 0 Failed, 88 Passed
🔻 Test Sessions change in coverage: 2 decreased, 1 increased (+0.04%), 197 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
air-discount-scheme-backend	0	0	0	63	0	15.78s	N/A	Link
air-discount-scheme-web	0	0	0	2	0	6.56s	N/A	Link
api	0	0	0	4	0	3s	N/A	Link
api-catalogue-services	0	0	0	23	0	11.9s	N/A	Link
api-domains-air-discount-scheme	0	0	0	6	0	21.08s	N/A	Link
api-domains-assets	0	0	0	3	0	12.32s	N/A	Link
api-domains-auth-admin	0	0	0	18	0	13.43s	1 no change	Link
api-domains-communications	0	0	0	5	0	34.84s	N/A	Link
api-domains-criminal-record	0	0	0	5	0	10.1s	N/A	Link
api-domains-driving-license	0	0	0	23	0	28.03s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (2)

• message-queue - jest 67.46% (-0.8%) - Details
• application-system-api - jest 35.56% (-0.05%) - Details