-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added InterAppCommunication via /dev/iac #315
base: master
Are you sure you want to change the base?
Conversation
Thanks for taking the time to implement this! On first look this seems pretty good. One thing I'd want adjusted is the device number, which is currently 1,99. I would want to reserve an entire major number for iSH devices, and define an API for adding custom entries to the array in fs/dev.c. Looking at the list of allocated major numbers, 240 seems like a good choice, since major numbers from 240 to 254 are reserved for devices with no actual official major number. I'll review this a bit more later. |
No problem :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a selection of unsolicited review that I thought you might find useful.
This reverts commit 192ec35.
What is needed to merge this? |
You have also to add TARGET_IS_EXTENSION in "Preprocessor Macros" like in this screen
To test:
Could be used to with Shortcut apps via something like