Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License compatibility #13

Open
siikamiika opened this issue Nov 9, 2020 · 1 comment
Open

License compatibility #13

siikamiika opened this issue Nov 9, 2020 · 1 comment

Comments

@siikamiika
Copy link

Hi there and thanks for your work on this library! I'm working on a project that implements YouTube live chat replay along with some normal YouTube functionality for archived videos. I haven't yet decided how to license it, but it'll probably be a more permissive one than GPL-3.0.

If I include the files in this library and its license file along with the following code, do I have to license my project under GPL-3.0 too? I'm not sure if mere aggregation applies when sharing a video ID and 2 DOM elements between the codebases.

(async () => {
    const video = document.querySelector('#video');
    const videoContainer = document.querySelector(".video-container");

    const parser = new AnnotationParser();
    const xmlData = await (await fetch(`/storage/annotations/${app.videoId}.xml`)).text();
    const annotationElements = parser.getAnnotationsFromXml(xmlData);
    const annotations = parser.parseYoutubeAnnotationList(annotationElements);

    const renderer = new AnnotationRenderer(annotations, videoContainer, {
        getVideoTime() {
            return video.currentTime;
        },
        seekTo(seconds) {
            video.currentTime = seconds;
        },
        getOriginalVideoWidth() {
            return video.videoWidth;
        },
        getOriginalVideoHeight() {
            return video.videoHeight;
        }
    });
    renderer.start();

    window.addEventListener("resize", e => {
        renderer.updateAllAnnotationSizes();
    });
})();

You can also convince me to use GPL for my project :)

@isaackd
Copy link
Owner

isaackd commented Sep 13, 2022

I am very sorry for not seeing this when it was opened! Honestly, I'm not very familiar with licenses (especially so when I started this project) so my reasoning for choosing GPL3 is mostly copying others. Are you still working on this project? I am 100% open to getting this to a more permissive license if you're still interested. Just let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants