-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click functions on children of items don't fire on touch events #557
Comments
Thanks for reporting. I'll try to make time tomorrow or early next week to look into possible solutions |
same issue here, thanks @Draconizations for the workaround |
Damn, it doesn't reproduce for me in the browser using emulation or on my Google Pixel. |
it seems like using a button for a drag handle causes some issues https://svelte.dev/repl/02030329daf64b129ffe3adbf3cf1403?version=4.2.15 |
ok, noticed something much weirder and the actual reason why I started experience this bug in the first place https://svelte.dev/repl/df0a77452e324e10bd205aa6d613125d?version=4.2.15 |
i have the same problem, as i can see touchend not check what i click not on the nodeElement. Please add in all places e.target.click && e.target.click() instead e.target.click() |
0.9.43 introduces a bug where click functions of children of items (i.e. a button inside a dnd item) will not fire on touch devices. Calling e.stopPropagation or e.stopImmediatePropagation in the child click handler does not work here.
There is a workaround. Adding a touchend listener to the child element, with the same handler as the onclick listener, seems to function identically to the old behavior, and it doesn't activate after actually dragging the item.
Figured I'd open an issue, in case there is an actual fix that can be added to the library itself. As well as notify others that there is a workaround here.
The text was updated successfully, but these errors were encountered: