Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DestinationNode needs js AudioNodeMixin to handle panics #81

Closed
orottier opened this issue Feb 21, 2024 · 1 comment · Fixed by #82
Closed

DestinationNode needs js AudioNodeMixin to handle panics #81

orottier opened this issue Feb 21, 2024 · 1 comment · Fixed by #82

Comments

@orottier
Copy link
Collaborator

From #57 the tests in the-destinationnode-interface fail because the audioContext.destination.channelCount = 0; throws a rust panic that is not wrapped by a JS error. I looked in the js/ directory and there is no trace of DestinationNode. Should it be added?
@b-ma
Copy link
Collaborator

b-ma commented Feb 21, 2024

Nice catch! But trickier than expected, it seems to hide an issue with the wpt, I will investigate

@b-ma b-ma mentioned this issue Feb 21, 2024
Merged
@b-ma b-ma closed this as completed in #82 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement AudioNode interface for AudioDestinationNode ircam-ismm/node-web-audio-api
2 participants
@b-ma @orottier