Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to set lot numbers from the bulk add lots page #259

Open
iragm opened this issue Nov 1, 2024 · 1 comment
Open

Remove the ability to set lot numbers from the bulk add lots page #259

iragm opened this issue Nov 1, 2024 · 1 comment

Comments

@iragm
Copy link
Owner

iragm commented Nov 1, 2024

This caused some odd issues with adding rows. IMHO there's never (?) a reason to set lot numbers and this can be safely removed.

Admins can still set lot numbers one at a time on the lot management page, although no one seems to use this.

@iragm
Copy link
Owner Author

iragm commented Nov 11, 2024

Just discovered that if you change a lot's number, the HTMX call to reload the page raises 404 because the lot number is part of the URL.

And custom lot numbers can be too long and get cut off, although this is hacked around for the moment and is unlikely to happen anyway.

And there's #263.

And there's one admin who manually set their numbers because they didn't know it could be automatic.

These are adding up, and it seems like the right course of action is to remove the ability to set custom lot numbers. I need to audit things to make sure no one is actually using this, but to my knowledge no one is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant