Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feat/macos #23

Closed
wants to merge 4 commits into from
Closed

WIP: Feat/macos #23

wants to merge 4 commits into from

Conversation

Jorropo
Copy link

@Jorropo Jorropo commented Sep 8, 2020 •
edited
Loading

Closes: #1
The goal is to support darwin 64 (amd and arm).
I'm gonna add 32 bit if it works without any extra errors, else I'll not invest time in supporting 32 bits but luck may make it working on the first try.
My goal is to support IOS 64 (and I'm using this one as a base.).

EDIT: I don't have the time to do 32 bits.
EDIT 2: https://golang.org/doc/go1.15#darwin :

As announced in the Go 1.14 release notes, Go 1.15 drops support for 32-bit binaries on macOS, iOS, iPadOS, watchOS, and tvOS (the darwin/386 and darwin/arm ports). Go continues to support the 64-bit darwin/amd64 and darwin/arm64 ports.

I'll definitely not take the time to do darwin to 32 :)

@Jorropo Jorropo marked this pull request as draft September 8, 2020 12:09
@Jorropo Jorropo changed the title WIP: Feat/macos Feat/macos Sep 8, 2020
@Jorropo Jorropo marked this pull request as ready for review September 8, 2020 18:16
@Jorropo
Copy link
Author

Jorropo commented Sep 8, 2020 •
edited
Loading

@karalabe review pls ? :)
It works :
Capture d’écran du 2020-09-08 20-14-15
The bottom window (server) is an ssh into a mac mini. And this is running the example slightly tweaked (to print runtime.GOOS (that from there that "darwin" came)).
I've checked other things (onion3, client, ...) and wasn't able to find something not working.
And linux is still working (I havn't tested android but since I didn't touched these files at all, linux still working makes me confident about android working).
EDIT: It need to make a darwin specifical version (go run build/wrap.go must be runned in OSX first, I'll do this tomorow)

@Jorropo Jorropo marked this pull request as draft September 8, 2020 18:57
@Jorropo Jorropo changed the title Feat/macos WIP: Feat/macos Sep 8, 2020
This was referenced Sep 9, 2020
Closed
Closed
@Jorropo Jorropo closed this Sep 14, 2020
@Jorropo Jorropo deleted the feat/macos branch September 14, 2020 11:25
@Jorropo Jorropo restored the feat/macos branch September 18, 2020 12:40
@Jorropo Jorropo deleted the feat/macos branch September 18, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the macOS wrapper generator
1 participant
@Jorropo