Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix out of gas for new types tx #4507

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

envestcc
Copy link
Member

Description

estimategas as legacyTx for new types tx may cause OutOfGas error

based on #4479

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc changed the title [api] estimategas for new types tx [api] Fix out of gas for new types tx Nov 29, 2024
Copy link

sonarcloud bot commented Nov 29, 2024

@envestcc envestcc merged commit 584f187 into iotexproject:master Nov 29, 2024
3 checks passed
@envestcc envestcc deleted the estimategas branch November 29, 2024 08:45
dustinxie pushed a commit that referenced this pull request Dec 2, 2024
dustinxie pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants