-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evm] fix RevertSnapshot #4492
[evm] fix RevertSnapshot #4492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes after HF looks good to me, what about fix before HF?
No fix is needed before HF, IMO |
action/protocol/execution/evm/evm.go
Outdated
@@ -376,7 +376,9 @@ func prepareStateDB(ctx context.Context, sm protocol.StateManager) (*StateDBAdap | |||
if featureCtx.EnableCancunEVM { | |||
opts = append(opts, EnableCancunEVMOption()) | |||
} | |||
|
|||
if featureCtx.FixRevertSnapshot { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait PR4494 to merge, then check the ReadOnly
here
Quality Gate passedIssues Measures |
Co-authored-by: envestcc <[email protected]>
Description
as title.
Fixes #4491
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: