Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evm] fix RevertSnapshot #4492

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[evm] fix RevertSnapshot #4492

merged 3 commits into from
Nov 19, 2024

Conversation

dustinxie
Copy link
Member

Description

as title.

Fixes #4491

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link
Member

@envestcc envestcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes after HF looks good to me, what about fix before HF?

@CoderZhi
Copy link
Collaborator

Changes after HF looks good to me, what about fix before HF?

No fix is needed before HF, IMO

@@ -376,7 +376,9 @@ func prepareStateDB(ctx context.Context, sm protocol.StateManager) (*StateDBAdap
if featureCtx.EnableCancunEVM {
opts = append(opts, EnableCancunEVMOption())
}

if featureCtx.FixRevertSnapshot {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait PR4494 to merge, then check the ReadOnly here

Copy link

sonarcloud bot commented Nov 19, 2024

@dustinxie dustinxie merged commit 65044c7 into master Nov 19, 2024
3 checks passed
@dustinxie dustinxie deleted the fixrevert branch November 19, 2024 06:07
envestcc added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API call return "Failed to snapshot" error
3 participants