[factory] move SimulateExecution() out of factory interface #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
commented
Nov 7, 2024
state/factory/factory.go
Outdated
| PutBlock(context.Context, *block.Block) error | ||
| DeleteTipBlock(context.Context, *block.Block) error | ||
| StateAtHeight(uint64, interface{}, ...protocol.StateOption) error | ||
| StatesAtHeight(uint64, ...protocol.StateOption) (state.Iterator, error) | ||
| WorkingSetNotWritable(context.Context, uint64, bool) (protocol.StateManager, error) |
There was a problem hiding this comment.
create a workingset that is not writable
dustinxie
force-pushed
the
cleanfactory
branch
from
f6c620b to
b9b33b2
Compare
dustinxie
commented
Nov 7, 2024
state/factory/factory.go
Outdated
| ws *workingSet | ||
| err error | ||
| ) | ||
| // TODO: make the workingset not writable, cannot call commit() to write its content to DB |
CoderZhi
approved these changes
Nov 11, 2024
dustinxie
force-pushed
the
cleanfactory
branch
2 times, most recently
from
f28305d to
32a5529
Compare
envestcc
reviewed
Nov 12, 2024
There was a problem hiding this comment.
seems not required to wrap workingSet, b/c Commit is not exported in StateManager
envestcc
approved these changes
Nov 12, 2024
dustinxie
force-pushed
the
cleanfactory
branch
2 times, most recently
from
a5e711a to
6c872cd
Compare
dustinxie
force-pushed
the
cleanfactory
branch
from
6c872cd to
6f9c730
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2 methods don't need to be in the
factoryinterface.Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: