Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - Tools - Add Oracles #1423

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Build - Tools - Add Oracles #1423

merged 4 commits into from
Feb 1, 2024

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

Added article about oracles, including Supra and Pyth.

Links to any relevant issues

fixes #1407

Type of change

  • Documentation

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron marked this pull request as draft January 29, 2024 13:42
@Dr-Electron Dr-Electron marked this pull request as ready for review January 29, 2024 13:42
@lucas-tortora
Copy link
Collaborator Author

@lucas-tortora lucas-tortora marked this pull request as draft January 29, 2024 14:22
@lucas-tortora lucas-tortora marked this pull request as ready for review January 29, 2024 14:22
@lucas-tortora lucas-tortora marked this pull request as draft January 29, 2024 14:23
@lucas-tortora lucas-tortora marked this pull request as ready for review January 29, 2024 14:24
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9fd90c5

✅ Preview: https://iota-wiki-omempwpjg-iota1.vercel.app

Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if there is no other issues with ethers v6

@Dr-Electron Dr-Electron marked this pull request as draft January 29, 2024 15:09
@Dr-Electron Dr-Electron marked this pull request as ready for review January 29, 2024 15:09
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 29308ea

✅ Preview: https://iota-wiki-po66jeoqm-iota1.vercel.app

Copy link
Collaborator

@Phyloiota Phyloiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lucas-tortora lucas-tortora merged commit 5af6fd2 into main Feb 1, 2024
12 checks passed
@Dr-Electron Dr-Electron deleted the build-tools/addOracles branch February 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement important DeFi Infra Info: Oracles and Subgraphs
3 participants