New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable all lints in ruff #337

Merged

ocefpaf merged 2 commits into ioos:main from ocefpaf:ruff_all

Mar 5, 2024

Member

ocefpaf commented Mar 5, 2024 •

edited

Loading

This PR is a bit overwhelming and touches almost all the files but this is the best time to do this b/c we have only 1 real PR pending. Here we have:

all lints in ruff are enabled
many docstrings improvements
code should be all typed now
small performance fixes
some functions are now kwargs only and this may be seen as a breaking change, next version should reflect that

I'm planning on self-merging this to avoid conflicts with upcoming PRs.

ocefpaf added 2 commits

March 5, 2024 12:33


          enable all lints in ruff

c806b6c


          fix kw and refresh metadata

338bcb3

ocefpaf merged commit 5e45a0e into ioos:main

13 checks passed

ocefpaf deleted the ruff_all branch

March 5, 2024 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet