Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Talos] Wrong providerID after node provisioning #342

Open
ricottatosta opened this issue Nov 29, 2024 · 5 comments
Open

[Talos] Wrong providerID after node provisioning #342

ricottatosta opened this issue Nov 29, 2024 · 5 comments
Labels
kind/bug Something isn't working

Comments

@ricottatosta
Copy link

ricottatosta commented Nov 29, 2024

What steps did you take and what happened:
I have been using the following components:

  • cluster-api:v1.7.2
  • talos-boot:v0.6.5
  • talos-cp:v0.5.6
  • ipam-in-cluster:v0.1.0
  • talos-ccm:v1.6.0 (running in managed cluster)

Untill capmox v0.3.0, talos-ccm has been able to set the right providerID to a new node, eg. proxmox://[unique_id].
But as of capmox v0.4.0, witih every release of capmox (I tested them all), providerID gets set to talos://nocloud/[node_ip].
Is there any brand new mechanism doing the same thing before talos-ccm? Or does talos-ccm do it wrong?

What did you expect to happen:
I would like talos-ccm to be able to set the right providerID.

Anything else you would like to add:
I am pretty sure talos-ccm sets node's providerID, because before I started using it, no providerID got set.
Am I supposed to no longer use talos-ccm?

Environment:

  • Cluster-api-provider-proxmox version: v0.4.0 and later
  • Kubernetes version: (use kubectl version): v1.28.3
  • OS (e.g. from /etc/os-release): Talos v1.6.8
@ricottatosta ricottatosta added the kind/bug Something isn't working label Nov 29, 2024
@mcbenjemaa
Copy link
Member

Capmox now also has providerId in the metadata.
provider-id

@ekarlso used that to initialize the nodes

@ricottatosta
Copy link
Author

Yes, I know about that. But I don't know neither @ekarlso setup nor if next releases will be effective against my setup.
And that's for the future.
For the past, all my own deployments depends on a capmox controller I modify and rebuild. Untill release 0.3.0 my own changes work well with Talos, but since 0.4.0 it's no longer the same. I would like to know what changes in capmox releases later than 0.3.0 have been affecting mine.
It would be a pity if I had to give up using Talos cloud controller manager as it does more than setting a providerId.

@wikkyk
Copy link
Collaborator

wikkyk commented Dec 5, 2024

#347 makes provider-id opt-in.

@mcbenjemaa
Copy link
Member

Please check with the new release v0.6.0

@wikkyk
Copy link
Collaborator

wikkyk commented Dec 9, 2024

Actually, please check with v0.6.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants