Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) ability to specify a ca-bundle to be added to each node #331

Open
lknite opened this issue Nov 24, 2024 · 2 comments
Open

(feature) ability to specify a ca-bundle to be added to each node #331

lknite opened this issue Nov 24, 2024 · 2 comments
Labels
enhancement New feature or request kind/feature

Comments

@lknite
Copy link

lknite commented Nov 24, 2024

Describe the solution you'd like
In the same way a 'vlan' can be specified, the ability to specify a ca-bundle e.g.:

  ca-bundle: |
    -----BEGIN CERTIFICATE-----
    MIIDMjCCAhqgAwIBAgIUSP49TU8ftntqg6TydaMjHclmp8QwDQYJKoZIhvcNAQEL
    ...
   GD8cgbW4
   -----END CERTIFICATE-----
    -----BEGIN CERTIFICATE-----
    MIIDMjCCAhqgAwIBAgIUSP49TU8ftntqg6TydaMjHclmp8QwDQYJKoZIhvcNAQEL
    ...
   GD8cgbW4
   -----END CERTIFICATE-----

Anything else you would like to add:
It should be possible to specify multiple certs, and later update-ca-trust would be used (or whatever technique is used by the distribution being used) to import the certs.

Use case:
I deployed harbor and generated certs via cert-manager using vault. Via pipelines I've built images and pushed images to harbor. Now I'd like to deploy images via harbor, but by default the harbor certs are not trusted, and worker nodes are unable to pull images.

@lknite lknite added enhancement New feature or request kind/feature labels Nov 24, 2024
@wikkyk
Copy link
Collaborator

wikkyk commented Dec 5, 2024

Related: #192

@lknite
Copy link
Author

lknite commented Dec 7, 2024

I got the idea for this feature from vmware Tanzu, where a single tanzuserviceconfig has the ca-bundle and it is applied to all nodes of all clusters.

Being able to set the ca-bundle makes this common configuration part of deploying the cluster / gitops.

Even better would be if updating the setting and reapplying would roll the cluster nodes one at a time updating the ca-bundle on each.

Current non-gitops alternatives:

  • add to template image after its built, not currently part of image-builder
  • everyone reinvents a script to remote over to each node and set the bundle / restart the needed services

Alternatively, maybe the namespace where the cluster.yaml is deployed and seen by capi could have the ca-bundle, and if it exists it gets applied to workernodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants