-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swipe to go back anywhere on view #27743
Comments
Thanks for the report. Do you have a video of how you are expecting this behavior to work? |
Here you go! FWIW, this was a feature on Apollo for Reddit. IMG_2710.mp4 |
Thanks for the video. Is this a video of Apollo, or is it a video of your app? Ionic currently supports swiping from the edge of the screen for swipe to go back. |
This video is wefwef, not Apollo. Swiping from the left edge of screen works great; we'd like the option to allow swiping to go back where the event initiates anywhere on the screen, not just the left edge. |
Do you have examples of other apps that implement this? Apollo has shut down, so I'm not able to see how this behavior would work. |
RPReplay_Final1688588264.mp4Like this (example of the Reddit app, which partially has it). Apollo solved it by disabling the other gestures. In Apollo you could also do an additional swipe to the subreddit list, which would be intuitive here as well. |
Thanks for the video. It looks like you can also do this with the Slack mobile app. It sounds like this feature request is more about being able to swipe anywhere on the view to go back than being able to swipe anywhere on the screen. For example, you should not be able to swipe back on the tab bar because the tab bar is not part of the child view. However, with this feature request users would not be limited to swiping only on the starting edge of the view. I think this would be a good feature to have. |
On a related note: How did you suppress the native iOS page transition on your app when using it as a PWA? Typically when you swipe on a child page Ionic's page transition as well as the native iOS page transition activates. However, in your app only the Ionic one activates. |
Oh, that's a fun hack: I detect if the webapp is installed (and is iOS) and then use the memory router :) https://github.com/aeharding/wefwef/blob/main/src/Router.tsx |
That sounds great! However I feel like I should mention that in Apollo, you can always swipe anywhere on the tab bar to initiate a swipe gesture to go back a page. So even if you have full page swipe turned off for the app, it's a nice shortcut. 🙂 (Likely out of scope for this feature request, and totally a non-standard thing, but might be worth consideration.) |
Oh clever! I have been trying to get a feature added to the Web Manifest that would allow devs to disable the native gestures so they can use URL-based routing: w3c/manifest#1041. I think having a use case like yours would go a long way in making the case for this feature. |
Prerequisites
Describe the Feature Request
Swipe to go back with the gesture initiating anywhere on the screen
Describe the Use Case
Users have:
that prevents, or make it difficult to, swipe from the left edge of the device.
Describe Preferred Solution
Option to enable/disable full screen page swipe
Describe Alternatives
I do not believe this is possible to implement without a library change.
Related Code
No response
Additional Information
Request from users of wefwef: https://lemmy.world/post/1028383
Related issue: aeharding/voyager#101
The text was updated successfully, but these errors were encountered: