Improve the regex finding ip-address-esque content

[fhightower]

We fang anything matching this regex: (?:^|(?<=\s))([0-9]{1,3}),([0-9]{1,3}),([0-9]{1,3}),([0-9]{1,3})(?=\s|$)... we should improve the regex to be more accurate and avoid false positives.

[devbazregari]

what do you mean of " improving " ?!
would you please give me one example with this regexp ?!

[fhightower]

Hi @devbazregari, thanks for asking!

The problem is that the current regex matches more than just valid ip addresses. For example, the current regex would match 999,999,999,999. But we don't want to match 999,999,999,999 because this isn't a valid ip address.

In other words, we want to refine the regex so that it only matches strings which would be valid ip addresses once the , characters are replaced with . characters. Does that help clarify?

You can see more examples of what we do and do not want this regex to match here.

Would you like to work on this? I'm happy to help and advise as needed.

[devbazregari]

thank you , i got it .

[devbazregari]

bro did my code was usefull?
I passed the test you attached to this website https://regexr.com/6u78s

[fhightower]

Sorry for the late reply - thank you for the PR! I'll take a look at it soon and will follow up with comments in the PR. Thanks 🎉 !

[devbazregari]

Ur Welcome