Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data download #14

Open
j-phi opened this issue Sep 17, 2017 · 3 comments
Open

Data download #14

j-phi opened this issue Sep 17, 2017 · 3 comments

Comments

@j-phi
Copy link

j-phi commented Sep 17, 2017

So it could absolutely just be me misunderstanding the instructions, but when I ran 'python download_sample_data.py' from the root of the clone of this repo (in my case, that's ./scipy-2017-holoviews-tutorial), the nyc_taxi.csv file was downloaded to the ./scipy-2017-holoviews-tutorial/data/ directory and it looks like it needs to be in the ./scipy-2017-holoviews-tutorial/notebooks/assets/ directory.

@jlstevens
Copy link
Member

... it looks like it needs to be in the ./scipy-2017-holoviews-tutorial/notebooks/assets/ directory.

I don't think we expect the data to go there and the ./scipy-2017-holoviews-tutorial/data/ location does seems correct to me. What did you see that suggested the .csv file ought to be in assets?

@j-phi
Copy link
Author

j-phi commented Sep 18, 2017

In /notebooks/00-welcome.ipynb just above Recommended Configuration:

import os if not os.path.isfile('./assets/nyc_taxi.csv'): print('Taxi dataset not found.')

@philippjfr
Copy link
Member

Thanks @j-phi, I believe the actual notebooks look for it in ./data so we'll update that asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants