Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Remove the adapter-core override after v7 #2933

Open
1 task done
foxriver76 opened this issue Oct 1, 2024 · 0 comments
Open
1 task done

[enhancement]: Remove the adapter-core override after v7 #2933

foxriver76 opened this issue Oct 1, 2024 · 0 comments

Comments

@foxriver76
Copy link
Collaborator

foxriver76 commented Oct 1, 2024

No existing issues.

  • There is no existing issue for my request.

Description

The temporary solution has the downside, that adapters can no longer specify the version required.
We then have an override in v6 + v7 so every user should once have these version to get the fixes in. Note on new installations etc this is not an issue at all because npm will pull in newer versions anyway.

Why?

The override blocks specyfing different versions and tightly binds adapter-core version to the controller

How?

Modify the override code:

  • do no longer create the override
  • remove the override from pack json programmaticaly
  • remove the override info from readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant