Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the additional npm-modules update process (controlled or disabled update process) #1759

Open
seb2010 opened this issue Nov 13, 2024 · 2 comments

Comments

@seb2010
Copy link

seb2010 commented Nov 13, 2024

Is your feature request related to a problem? Please describe.
In the instance configuration, you have the option to specify additional npm-module package to be installed for the instance. These packages then get available in the javascript-instance code.
With every start of the instance, the modules are updated to the latest version. This potentially disrupts the stability of the script, as breaking changes in packages might slip in unnoticed and you are only getting to know of it by monitoring the log closely.

Describe the solution you'd like
There are mutliple options:

  • Minimum feature should be an instance-configuration option to maintain the current version of the loaded packages. With this, nothing will change unwillingly. This could either be as described an opt-out option for updates or an opt-in option.
  • Similar to the adapter-panel and the notification on updates, this could also be done for the javascript instance. The user could be notified of npm-packges with available updates and trigger of the update process himself. After such an event, he could monitor the behaviour for errors due to breaking changes. This would replace the current auto-update method.

I would prefer option 2

Describe alternatives you've considered
Close monitoring of the log. But for 24/7 systems, you will eventually end up with unnoticed errors for a longer period of time.

Additional context
Add any other context or screenshots about the feature request here.

@klein0r
Copy link
Collaborator

klein0r commented Nov 13, 2024

  • Minimum feature should be an instance-configuration option to maintain the current version

Just specify it in the instance settings. e.g. [email protected]

@seb2010
Copy link
Author

seb2010 commented Nov 13, 2024

yes, agreed. I am just highlighting this as an additional feature, to avoid surprises.
You need to know, that the modules will get automatically updated via the current process. I did not know that and neither will other users, which might even not understand why something broke over time.
If we want to stick with the as is situation, we at least should add a remark on top of the configuration row, highlighting this situation and explaining the solution to add the specific version to the package with @x.x.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants