Explicit assignment execution fails for assignments that have never been built #28
Comments
|
Actually, I think that the assignment service should clone a repository if it doesn't exist. It shouldn't attempt to update an existing repository. The reason is that the assignment service is responsible for creating the various bits of database state that say that an assignment has started executing. We want the clone time and information to be included in the assignment execution logs. |
|
The repository service needs restructuring. It should be rewritten to be as isolated as possible; nothing else should be reading the repository database state. Any other services that need to do things with repositories must make synchronous calls to the repository service. |
io7m
added a commit
that referenced
this issue
Apr 14, 2024
This restructures the repository service such that it is now the authority when it comes to updating repositories and writing any repository-related database state. Affects: #28
io7m
added a commit
that referenced
this issue
Apr 14, 2024
Adjust how branches and tags are calculated, and improve error logging. Affects: #28
io7m
added a commit
that referenced
this issue
Apr 14, 2024
Ensure that directories are created for output files. Affects: #28
io7m
added a commit
that referenced
this issue
Apr 17, 2024
* Classify repository events under their own sealed interface * Create a single-transaction interface for brevity * Implement more metrics Affects: #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Specifically the
NPUCommandAssignmentExecutecommand will call the assignment service directly. The assignment service is not responsible for making sure that the repository associated with the assignment exists or is up-to-date. It might be better for the command to call the scheduling service instead. This makes slightly more conceptual sense... "Schedule this assignment to run right now."The text was updated successfully, but these errors were encountered: