Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for undefined values in SettingsList #8531

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

SchrodingersGat
Copy link
Member

No description provided.

@SchrodingersGat SchrodingersGat added the Platform UI Related to the React based User Interface label Nov 20, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 20, 2024
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 995e30a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673da3b6fd700600080fc335
😎 Deploy Preview https://deploy-preview-8531--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (41a9b68) to head (995e30a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/frontend/src/components/settings/SettingList.tsx 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8531      +/-   ##
==========================================
- Coverage   84.66%   84.56%   -0.10%     
==========================================
  Files        1178     1178              
  Lines       53584    53584              
  Branches     2026     2026              
==========================================
- Hits        45366    45314      -52     
- Misses       7696     7745      +49     
- Partials      522      525       +3     
Flag Coverage Δ
pui 69.00% <0.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SchrodingersGat SchrodingersGat merged commit 13440a6 into inventree:master Nov 20, 2024
27 checks passed
@SchrodingersGat SchrodingersGat deleted the settings-list-fix branch November 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants