Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Switch to websockets for progress bars/notifications #6262

Open
2 tasks done
matmair opened this issue Jan 16, 2024 · 2 comments · May be fixed by #7724
Open
2 tasks done

[FR] Switch to websockets for progress bars/notifications #6262

matmair opened this issue Jan 16, 2024 · 2 comments · May be fixed by #7724
Assignees
@matmair
Labels
enhancement This is an suggested enhancement or new feature
Milestone
1.0.0

Comments

@matmair
Copy link
Member

matmair commented Jan 16, 2024

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

Currently we need to reload pages/run constant fetching to get results of long running tasks/changed page details. That leads to unneeded traffic.

Suggested solution

After #6173 is merged we can introduce websockets and use them for notifications, progress bars, page indiactors and more

Describe alternatives you've considered

The current way works well enough

Examples of other systems

No response

Do you want to develop this?

  • I want to develop this.
@matmair matmair added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Jan 16, 2024
@matmair matmair added this to the horizon milestone Jan 16, 2024
@matmair matmair removed the triage:not-checked Item was not checked by the core team label Jan 16, 2024
@matmair matmair self-assigned this Jan 16, 2024
@SchrodingersGat
Copy link
Member

Sounds like that would offer a huge improvement!

@matmair
Copy link
Member Author

matmair commented Jan 17, 2024

This depends on the migration to Django 4 but after that it should be simple - I have a bunch of projects with this setup. I can just borrow the structure from there.

@matmair matmair modified the milestones: horizon, 0.15.0 Feb 15, 2024
@SchrodingersGat SchrodingersGat modified the milestones: 0.15.0, 0.16.0 Apr 25, 2024
matmair added a commit to matmair/InvenTree that referenced this issue Jul 24, 2024
@matmair
[FR] Switch to websockets for progress bars/notifications
2b7a460 
Fixes inventree#6262
@matmair matmair linked a pull request Jul 24, 2024 that will close this issue
Draft
@SchrodingersGat SchrodingersGat modified the milestones: 0.16.0, 0.17.0 Aug 5, 2024
@matmair matmair modified the milestones: 0.17.0, 1.0.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matmair matmair

Labels
enhancement This is an suggested enhancement or new feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

WIP: Websockets matmair/InvenTree
2 participants
@SchrodingersGat @matmair