Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Improvement of string marked for translation needed #524

Open
chriz-uniba opened this issue Jun 9, 2022 · 1 comment
Open

i18n: Improvement of string marked for translation needed #524

chriz-uniba opened this issue Jun 9, 2022 · 1 comment

Comments

@chriz-uniba
Copy link
Contributor

The following string isn't marked nicely for translation:

{i18next.t('Uploading the selected files would result in')}{' '}
{humanReadableBytes(
filesSize + acceptedFilesSize,
decimalSizeDisplay
)}
{i18next.t('but the limit is')}
{humanReadableBytes(quota.maxStorage, decimalSizeDisplay)}.

See inveniosoftware/invenio-app-rdm#1718 for further explanation and solutions.

Subissue of inveniosoftware/invenio-app-rdm#1707

@chriz-uniba
Copy link
Contributor Author

It looks like the humanReadableBytes aren't localised (meaning that in the German translation it says 0 bytes instead of 0 Bytes) --- is there a way to localise this?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant