Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies is missing for poetry. #83

Open
jma opened this issue Aug 8, 2022 · 0 comments
Open

Dependencies is missing for poetry. #83

jma opened this issue Aug 8, 2022 · 0 comments
Labels

Comments

@jma
Copy link

jma commented Aug 8, 2022

Package version (if known): 1.4.12

Describe the bug

In the new 1.4.12 version a pyproject.toml has been created. Unfortunately, poetry consider pyproject.toml for entrypoints and dependencies instead of setup.py file. Thus when an invenio instance using poetry try to install pytest-invenio>1.4.11 all configuration present in the setup.py and not in the pyproject.toml is ignored.

Steps to Reproduce

  1. Create a invenio-instance with poetry see: https://github.com/rero/rero-ils/blob/staging/pyproject.toml for example.
  2. Install the project.
  3. the pytest command does not recognize the --pycodestyle option as the pytest-pydocstyle package is not installed

Expected behavior

All configuration present in the setup.py should be present in the pyproject.toml: dependencies, entrypoints, etc.

@jma jma added the bug label Aug 8, 2022
jma added a commit to jma/rero-ils that referenced this issue Aug 8, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Aug 8, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
rerowep added a commit to rerowep/rero-mef that referenced this issue Aug 8, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Aug 8, 2022
* fixes pytest-invenio problems with `poetry`. See: inveniosoftware/pytest-invenio#83

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-mef that referenced this issue Aug 8, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Peter Weber <[email protected]>
jma added a commit to rero/rero-ils that referenced this issue Aug 8, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
rerowep added a commit to rero/rero-mef that referenced this issue Aug 10, 2022
The new 1.4.12 version of pytest-invenio is not `poetry` friendly. See:
inveniosoftware/pytest-invenio#83 for more
details.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rero/rero-ebooks that referenced this issue Aug 10, 2022
* fixes pytest-invenio problems with `poetry`. See: inveniosoftware/pytest-invenio#83

Co-Authored-by: Peter Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant