Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changer checklist #1

Open
krzysztof opened this issue Mar 12, 2018 · 9 comments
Open

Changer checklist #1

krzysztof opened this issue Mar 12, 2018 · 9 comments

Comments

@krzysztof
Copy link
Member

krzysztof commented Mar 12, 2018 •
edited
Loading

Checklist for license changer QA:

  • git grep -i "GPL"
  • git grep -i "pypy"
  • Non-Invenio packages (e.g. "dcxml"), should not have "Invenio" in the license headers and probably nowhere in the code anywhere: git grep -i Invenio
  • Review the list of authors in AUTHORS.rst. Should be no duplicate names.
  • Check if README.rst has updated version tag badge and that the Image (shield.io) and the URL resolve to PyPy package repo
  • All commits should be made by "Invenio <[email protected]>"
@switowski
Copy link
Member

switowski commented Mar 21, 2018 •
edited
Loading

  • AUTHORS.rst:
    • Check if the list of contributors in was changed (No duplicates? No weird names?)
    • Check if there is license on top of the file
  • Check if .travis.yml has:
    • allow_failures specifying tests that are using env: REQUIREMENTS=devel ...
    • username for pypi: inveniosoftware
    • changed password for pypi

@krzysztof
Copy link
Member Author

krzysztof commented Mar 21, 2018 •
edited
Loading

Repositories which require manual version bump:

  • dcxml
  • citeproc-py-style
  • invenio-search-js

EDIT: (DONE)

@krzysztof
Copy link
Member Author

We need to check which other repositories will have to have those versions bumped in the dependencies

@slint already mentioned: invenio-search-js is a dependency of invenio-records-ui via it's asset bundle...
dcxml of invenio-record-rest[dublincore]

@krzysztof
Copy link
Member Author

Invenio-search needs to have changes.rst updated

@krzysztof
Copy link
Member Author

krzysztof commented Mar 21, 2018 •
edited
Loading

First batch to review:

@krzysztof
Copy link
Member Author

krzysztof commented Mar 21, 2018 •
edited by lnielsen
Loading

Second batch:

@lnielsen
Copy link
Member

lnielsen commented Mar 21, 2018 •
edited by slint
Loading

Third batch:

@krzysztof
Copy link
Member Author

krzysztof commented Mar 21, 2018 •
edited by lnielsen
Loading

Fourth batch:

@lnielsen
Copy link
Member

lnielsen commented Mar 21, 2018 •
edited by slint
Loading

5th batch:

6th batch:

7th batch:

8th batch:

9th batch:

10th batch:

11th batch:

12th batch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krzysztof @lnielsen @switowski