You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have a special configuration called RECORDS_REST_SORT_OPTIONS that specifies the sort configuration for each index.
It can be error prone because the user have to specify the index name inside RECORDS_REST_ENDPOINTS and, in the same time, inside RECORDS_REST_SORT_OPTIONS.
In addition, It is not intuitive because the convention for the dictionary key is different from RECORDS_REST_ENDPOINTS (where as key is used the pid_type).
Inside sorter.py we set the sort options to the search_class. So, why we don't do it directly?
Proposal
Can we directly specify the default sort configuration inside the search class and remove RECORDS_REST_SORT_OPTIONS?
could you share the configuration inside the seach_class as you say in #64 proposal 1?
It looks like the natural point where share the configuration for facets, sort, index, doc_type and max_result_window.
Problem
Currently we have a special configuration called
RECORDS_REST_SORT_OPTIONS
that specifies the sort configuration for eachindex
.RECORDS_REST_ENDPOINTS
and, in the same time, insideRECORDS_REST_SORT_OPTIONS
.RECORDS_REST_ENDPOINTS
(where askey
is used thepid_type
).search_class
. So, why we don't do it directly?Proposal
Can we directly specify the default sort configuration inside the search class and remove
RECORDS_REST_SORT_OPTIONS
?cc @inveniosoftware/triagers
see #99
The text was updated successfully, but these errors were encountered: