Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC URL endpoint building #101

Closed
hachreak opened this issue Jul 19, 2016 · 2 comments · Fixed by #119
Closed

RFC URL endpoint building #101

hachreak opened this issue Jul 19, 2016 · 2 comments · Fixed by #119
Assignees
@nikofil
Labels
Type: discussion

Comments

@hachreak
Copy link
Member

hachreak commented Jul 19, 2016 •
edited
Loading

There is a specific reason why to construct the url endpoint is used the key of RECORDS_REST_ENDPOINTS and sometimes the pid_type?
See:

Can we simplify and use only one way?
Maybe the best solution is to use the pid_type everywhere. WDYT? There are some contraindications?

ping @jirikuncar @lnielsen @tiborsimko
@jirikuncar jirikuncar changed the title [RFC] url endpoint building RFC URL endpoint building Jul 19, 2016
@jirikuncar
Copy link
Member

There must exist one key per pid_type (see https://github.com/inveniosoftware/invenio-records-rest/blob/master/invenio_records_rest/utils.py#L104-L126). However, one can have multiple endpoints for same pid_type. We will have to address it in #99 and #100.

@hachreak hachreak mentioned this issue Aug 8, 2016
Closed
@tiborsimko tiborsimko mentioned this issue Aug 10, 2016
Closed
10 tasks
nikofil added a commit to nikofil/invenio-records-rest that referenced this issue Aug 31, 2016
@nikofil
views: use endpoint pid_type instead of key for blueprints
f7de3f6 
* Changes views.py to use pid_type in the endpoint map instead of the key for
  the name of the endpoint. (closes inveniosoftware#101)

Signed-off-by: Nikos Filippakis <[email protected]>
@nikofil nikofil mentioned this issue Aug 31, 2016
Closed
@nikofil nikofil self-assigned this Aug 31, 2016
@kaplun
Copy link
Member

kaplun commented Sep 29, 2016

Hi! What is the status of this issue? In INSPIRE we are trying to move to official invenio-pidstore, (see inveniosoftware/invenio-pidstore#63 (comment)) but this is currently blocked by this specific usage of pid_type in building the endpoints.

kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Sep 30, 2016
@kaplun
config: RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT
236db26 
* NEW Introduces new RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT config
  variable, needed in order to know which default endpoint corresponds
  to which pid_type when building URIs. (closes inveniosoftware#101)

Signed-off-by: Samuele Kaplun <[email protected]>
@kaplun kaplun mentioned this issue Sep 30, 2016
Merged
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Sep 30, 2016
@kaplun
config: RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT
a98bffc 
* NEW Introduces new RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT config
  variable, needed in order to know which default endpoint corresponds
  to which pid_type when building URIs. (closes inveniosoftware#101)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 5, 2016
@kaplun
config: RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT
84d2f6a 
* NEW Introduces new RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT config
  variable, needed in order to know which default endpoint corresponds
  to which pid_type when building URIs. (closes inveniosoftware#101)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 5, 2016
@kaplun
config: RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT
8a47783 
* NEW Introduces new RECORDS_REST_PID_TYPE_DEFAULT_ENDPOINT config
  variable, needed in order to know which default endpoint corresponds
  to which pid_type when building URIs. (closes inveniosoftware#101)

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 5, 2016
@kaplun
utils: new get_default_endpoint_for()
3082054 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefix` prefix to explicitly
  declare which `endpoint-prefix` to use in case of ambiguity.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 5, 2016
@kaplun
utils: new get_default_endpoint_for()
518c9ab 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefix` prefix to explicitly
  declare which `endpoint-prefix` to use in case of ambiguity.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 5, 2016
@kaplun
utils: new get_default_endpoint_for()
a66a238 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefix` prefix to explicitly
  declare which `endpoint-prefix` to use in case of ambiguity.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 6, 2016
@kaplun
utils: new get_default_endpoint_for()
5637f3e 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefix` prefix to explicitly
  declare which `endpoint-prefix` to use in case of ambiguity.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 6, 2016
@kaplun
utils: new get_default_endpoint_for()
c6b3cf5 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 6, 2016
@kaplun
utils: new get_default_endpoint_for()
cbcaa92 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 6, 2016
@kaplun
utils: new get_default_endpoint_for()
d7a33b3 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 6, 2016
@kaplun
utils: new get_default_endpoint_for()
2e82dbf 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun
utils: new get_default_endpoint_for()
510012f 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun
utils: new get_default_endpoint_for()
32adc55 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun
utils: new get_default_endpoint_for()
5149c1a 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun
utils: new get_default_endpoint_for()
a83784b 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun
utils: new get_default_endpoint_for()
2f6a69d 
* NEW Introduces new get_default_endpoint_for() helper to obtain the
  default endpoint-prefix to be used to build endpoints for a given
  `pid_type`. (closes inveniosoftware#101)

* NEW Introduces new `default_endpoint_prefixes` property to explicitly
  declare which `endpoint-prefix` to use for which `pid_type`.

Signed-off-by: Samuele Kaplun <[email protected]>
jirikuncar pushed a commit to jirikuncar/invenio-records-rest that referenced this issue Oct 7, 2016
@kaplun @jirikuncar
utils: default endpoint prefixes
c79ce2e 
* NEW Introduces new cached property on extension state called
 `default_endpoint_prefixes` that maps `pid_type` to an
 `endpoint-prefix` used to build endpoints. (closes inveniosoftware#101)

Reviewed-by: Jiri Kuncar <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikofil nikofil

Labels
Type: discussion
Projects
None yet
Milestone
No milestone
4 participants
@kaplun @jirikuncar @hachreak @nikofil