Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict modifications on files of deleted records #512

Closed
jrcastro2 opened this issue Sep 26, 2023 · 1 comment
Closed

Restrict modifications on files of deleted records #512

jrcastro2 opened this issue Sep 26, 2023 · 1 comment
Assignees
@jrcastro2

Comments

@jrcastro2
Copy link
Contributor 

          normally I would say you should not be able to set_file_content on deleted record unless for some reason the admin's job requires it. I would ask the zenodo support team for their use cases

I see two options

  1. this endpoint should be protected by permissions, and only admin should be able to set content/commit - in this case we miss a test to check if normal user or owner of the record still can commit files
  2. nobody, even the admin/moderator (except superuse) should be able to commit or set content

Originally posted by @kpsherva in #511 (comment)
@kpsherva
Copy link
Contributor

kpsherva commented Oct 4, 2023

done

@kpsherva kpsherva closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrcastro2 jrcastro2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrcastro2 @kpsherva