Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Type resets to public after editing redirect URI #264

Open
dfdan opened this issue Aug 17, 2024 · 2 comments
Open

Client Type resets to public after editing redirect URI #264

dfdan opened this issue Aug 17, 2024 · 2 comments

Comments

@dfdan
Copy link
Member

dfdan commented Aug 17, 2024

Package version (if known): v11 / current Zenodo

Describe the bug

If an OAUTH applicaiton is configured as 'confidential', editing/saving the redirect URIs appears to reset the client type to 'public'. THis can be frustrating

Steps to Reproduce

  1. Create a confidential OAUTH app, save it
  2. Edit it - add or edit a redirect uri
  3. Save it
  4. Note that the client type resets to 'public'

Expected behavior

I don't know if this is intentional behaviour for security reasons(?) - if it is, it would be worth a warning as its easily missed.
Ideally the client type would not get reset.
May happen with other settings, but I've only observed with redirect_uri repeatedly.

@dfdan
Copy link
Member Author

dfdan commented Aug 19, 2024

(Tagging @slint because we had some intrersting trouble potentially related to this. )

@slint
Copy link
Member

slint commented Aug 20, 2024

The underlying issue is that the form for creating the application is sending an empty value for the is_confidential field. In the end this boils down to the form setting the field to is_confidential=False, which means all applications are created as "Public".

The application "Edit" form correctly sends the value on POST, so it is possible to modify and persist the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants