Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Settings Page - Form elements must have labels #1075

Open
fenekku opened this issue Dec 6, 2023 · 1 comment
Open

Community Settings Page - Form elements must have labels #1075

fenekku opened this issue Dec 6, 2023 · 1 comment

Comments

@fenekku
Copy link
Contributor

fenekku commented Dec 6, 2023

Package version (if known): v11 up

Describe the bug

There is a critical WCAG 2.1 AA violation on the community settings page (/communities/<any test community>/settings):

in the page

form_elements_must_have_labels_in_situ

description from Axe devtool

form_elements_must_have_labels

Unfortunately this may be a wontfix issue. The problem is essentially on React-Semantic-UI side (see
Semantic-Org/Semantic-UI-React#4349 and some others more general): https://github.com/inveniosoftware/invenio-communities/blob/master/invenio_communities/assets/semantic-ui/js/invenio_communities/settings/profile/CommunityProfileForm.js#L403 does the right thing and passes the label with the appropriate for property. It's the react semantic ui that doesn't place the ARIA/accessible attributes properly.

A potential solution could be to implement our own accessible dropdown like we did on the record landing page, but we would need to wire it up with the form field system and that seems really daunting.

So maybe this is a ticket to just keep track of that problem.

@gutumd
Copy link

gutumd commented Dec 12, 2023

Hello there, I've faced same issue recently with the Dropdown component, and that's how I've solved it:
https://codesandbox.io/p/sandbox/semantic-ui-example-forked-2mvnx6?file=%2Fexample.js%3A38%2C24

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants