Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pods are not recreated when configmaps/secrets are changed #142

Open
lindhe opened this issue Dec 11, 2024 · 2 comments
Open

Pods are not recreated when configmaps/secrets are changed #142

lindhe opened this issue Dec 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lindhe
Copy link
Contributor

lindhe commented Dec 11, 2024

Currently, when a ConfigMap or Secret is changed any pod that uses environment variables from them needs to be restarted manually. We should force recreation.

See example here: https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
@lindhe lindhe added the bug Something isn't working label Dec 11, 2024
@egabancho
Copy link
Member

I guess we will have to include one annotation for each ConfigMap/Secret each pod uses, right?

@lindhe
Copy link
Contributor Author

lindhe commented Dec 15, 2024

exactly

egabancho added a commit that referenced this issue Dec 16, 2024
@egabancho
invenio: merge base config and extraConfig
d53464f 
* Adds annotation to force pod recreation in case of changes
  (addresses #142).
@egabancho egabancho mentioned this issue Dec 16, 2024
Closed
egabancho added a commit to egabancho/helm-invenio that referenced this issue Dec 16, 2024
@egabancho
invenio: merge base config and extraConfig
faf57e7 
* Adds annotation to force pod recreation in case of changes
  (addresses inveniosoftware#142).
@egabancho egabancho mentioned this issue Dec 16, 2024
Open
egabancho added a commit to egabancho/helm-invenio that referenced this issue Dec 17, 2024
@egabancho
invenio: merge base config and extraConfig
35649d4 
* Adds annotation to force pod recreation in case of changes
  (addresses inveniosoftware#142).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egabancho @lindhe