-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES6 support (migrate from module.exports to export const) #9
Comments
|
Good point. This issue could have been written better, the specific location I'd like to remove (if possible) is here: https://github.com/intuit/user-data-for-fraud-prevention/blob/master/src/js/index.js#L6 I will amend the description of the issue, thanks for taking a look! |
Hi @reubenae , can I take this up? |
@jitinmaher you are free to submit a PR, and we appreciate the contribution. We do not allow people to "claim" issues in advance as its too tricky to manage. Please make sure to test this with the demo project listed in the README.md using |
We're not sure here #45 - this needs more research done, so I recommend not working on this issue yet (unless you have a really good understanding of this sort of thing and can bring the repo maintainers up to speed!) |
At the moment we use module.exports in this repo occasionally, for example here https://github.com/intuit/user-data-for-fraud-prevention/blob/master/src/js/index.js#L6 . It would be better to have ES6 style
export const ...
instead.A stack overflow on this topic https://stackoverflow.com/questions/40294870/module-exports-vs-export-default-in-node-js-and-es6 likely this will require some babel configuration.
Tutorial https://egghead.io/lessons/javascript-how-to-write-a-javascript-library-adding-es6-support
This can be tested with using yarn-link locally.
The text was updated successfully, but these errors were encountered: