Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support #12

Open
reubenae opened this issue Sep 10, 2020 · 12 comments
Open

Add typescript support #12

reubenae opened this issue Sep 10, 2020 · 12 comments

Comments

@reubenae
Copy link
Contributor

reubenae commented Sep 10, 2020

Is your feature request related to a problem? Please describe.
As an engineer, I want to be able to write my code in typescript, so I can find out possible bugs at compile time.

Describe the solution you'd like
Typescript being a supported language in this repo

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This was attempted before (#28) but due to a series of merge conflicts, was closed without merging. I recommend approaching this in a piecemeal fashion. However, the previous PR is a good reference point for this work still.

@nsinghal12
Copy link

@reubenae Is this issue still available. If yes, I'd like to work on this.

@reubenae
Copy link
Contributor Author

@nsinghal12 absolutely! We had some snagging issues on Adam's PR, which never got merged. You can refer to that for next steps if you get stuck. I recommend raising small, incremental PR's so we can avoid big merge conflicts. Looking forward to your contribution!

@regromrob
Copy link

Hi @skodamarthi is this issue apart of this year's hacktoberfest in addition to Grace Hopper?

@skodamarthi
Copy link
Contributor

Hi @regromrob Yes...this is open for hacktoberfest as well. Contributions are welcome!

@regromrob
Copy link

Awesome @skodamarthi I would love to be assigned to this issue please.

@regromrob
Copy link

Hi! I actually ended up being really busy all of this month and won't have the time to tackle this ticket. I apologize for the inconvenience. Please unassign. Thank you!

@Vikki123
Copy link

Vikki123 commented Oct 3, 2022

Hi @reubenae @skodamarthi Shall i pick this up ?

@pmaidens
Copy link
Contributor

pmaidens commented Oct 7, 2022

@reubenae I think we can close this issue since #164 was merged. Do we also want to create a new issue to start migrating files from JavaScript to TypeScript? Or do you prefer to just have that happen naturally?

@reubenae
Copy link
Contributor Author

reubenae commented Oct 7, 2022

I won't have access to my laptop for a couple of days so can't add an issue for the file migration - but absolutely happy for that to happen deliberately rather than over time. So if you fancy a crack at that, go ahead! Small PR's better than large ones though please!

@reubenae
Copy link
Contributor Author

@pmaidens I'm back with laptop access now so feel free to make a PR and/or new issue as you wish, and I will review!

@reubenae
Copy link
Contributor Author

This issue is being worked on, but there is lots of work to go around. If you're looking at this for some work, please keep your PR's small so that merge conflicts are avoided and wasted work limited.
Thanks to Peter who has been leading the charge on this!

@pmaidens
Copy link
Contributor

One of the most important things left for us to do here is that we need to publish our types for external consumption, and tie that into the exported functions to ensure we maintain those contracts.

The other major piece left is to migrate tests to TypeScript as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants