From 53c6816a0314f9f212f970a02bd6ab43aa44b31d Mon Sep 17 00:00:00 2001
From: Steffen Moldenhauer <54577793+smoldenhauer-ish@users.noreply.github.com>
Date: Tue, 7 Jan 2025 17:30:10 +0100
Subject: [PATCH 1/3] feat(icm): jgroups location directory configurable (#865)

---
 .../icm-as/templates/jgroups-config-xml-cm.yaml |  6 +++---
 charts/icm-as/tests/jgroups-config_test.yaml    | 17 +++++++++++++++++
 charts/icm-as/values.yaml                       |  6 +++++-
 3 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/charts/icm-as/templates/jgroups-config-xml-cm.yaml b/charts/icm-as/templates/jgroups-config-xml-cm.yaml
index ec8a0ad2..4233f14e 100644
--- a/charts/icm-as/templates/jgroups-config-xml-cm.yaml
+++ b/charts/icm-as/templates/jgroups-config-xml-cm.yaml
@@ -46,7 +46,7 @@ data:
 {{- else if eq (include "icm-as.jgroups.discovery" .) "file_ping" }}
         <!-- discover nodes by shared FS -->
         <FILE_PING
-          location="/intershop/jgroups-share"
+          location="{{ default "/intershop/jgroups-share" .Values.jgroups.location }}"
           remove_old_coords_on_view_change="true"
           remove_all_data_on_view_change="true"
           write_data_on_find="true"
@@ -58,7 +58,7 @@ data:
           container="${jgroups.azure_ping.container:ping}"
 {{- else if eq (include "icm-as.jgroups.discovery" .) "dns_ping" }}
         <!-- discover nodes using azure protocol -->
-        <dns.DNS_PING 
+        <dns.DNS_PING
           dns_query="{{ .Values.jgroups.dnsQuery }}"
 {{- end }}
           {{- if .Values.jgroups -}}
@@ -95,4 +95,4 @@ data:
         <FRAG2 frag_size="60000"  />
         <RSVP resend_interval="2000" timeout="10000"/>
         <pbcast.STATE/>
-    </config>
\ No newline at end of file
+    </config>
diff --git a/charts/icm-as/tests/jgroups-config_test.yaml b/charts/icm-as/tests/jgroups-config_test.yaml
index c9eb493e..bd28606c 100644
--- a/charts/icm-as/tests/jgroups-config_test.yaml
+++ b/charts/icm-as/tests/jgroups-config_test.yaml
@@ -14,6 +14,23 @@ tests:
       - matchRegex:
           path: data["jgroups-config.xml"]
           pattern: <FILE_PING*
+      - matchRegex:
+          path: data["jgroups-config.xml"]
+          pattern: location="/intershop/jgroups-share"
+  - it: jgroups-config.xml FILE_PING optional location
+    release:
+      name: icm-as
+    chart:
+      version: 0.8.15
+    values:
+      - ../values.yaml
+    template: templates/jgroups-config-xml-cm.yaml
+    set:
+      jgroups.location: "/intershop/other-jgroups-directory"
+    asserts:
+      - matchRegex:
+          path: data["jgroups-config.xml"]
+          pattern: location="/intershop/other-jgroups-directory"
   - it: jgroups-config.xml configured to use KUB_PING
     release:
       name: icm-as
diff --git a/charts/icm-as/values.yaml b/charts/icm-as/values.yaml
index 77ab5270..4fc59ae9 100644
--- a/charts/icm-as/values.yaml
+++ b/charts/icm-as/values.yaml
@@ -551,7 +551,6 @@ replication:
 
 # Configuration of messaging via jgroups
 jgroups:
-
   # the discovery protocol to use
   # supported values are file_ping or kube_ping. Defaults to file_ping, but kube_ping | azure_ping is recommended
   # file_ping (default) requires a mounted file system
@@ -560,6 +559,11 @@ jgroups:
   # dns_ping (playground) declared dns query
   discovery: file_ping
 
+  # location allows to set a different (optional) directory for file_ping discovery protocol
+  # it needs to point into an existing e.g. mounted file system storage that is shared to other application servers
+  # e.g. '/intershop/sites/root/jgroups'
+  location:
+
   # extra attributes to be added at the ping-section in xml,
   # e.g. 'readTimeout="1000" operationAttempts="5"'
   # discoveryExtraAttributes: <extra-attributes>

From d21dcf65e52c31a8541ac34e7d9a3a8e895ea21e Mon Sep 17 00:00:00 2001
From: khauser <khauser@users.noreply.github.com>
Date: Tue, 7 Jan 2025 16:31:14 +0000
Subject: [PATCH 2/3] chore: bump versions of icm-as:minor

---
 charts/icm-as/.bumpversion.toml          | 2 +-
 charts/icm-as/Chart.yaml                 | 2 +-
 charts/icm-replication/.bumpversion.toml | 2 +-
 charts/icm-replication/Chart.yaml        | 6 +++---
 charts/icm/.bumpversion.toml             | 2 +-
 charts/icm/Chart.yaml                    | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/charts/icm-as/.bumpversion.toml b/charts/icm-as/.bumpversion.toml
index 3e1825e6..7ee2ee41 100644
--- a/charts/icm-as/.bumpversion.toml
+++ b/charts/icm-as/.bumpversion.toml
@@ -1,5 +1,5 @@
 [tool.bumpversion]
-current_version = "2.4.1"
+current_version = "2.5.0"
 
 [[tool.bumpversion.files]]
 filename = "Chart.yaml"
diff --git a/charts/icm-as/Chart.yaml b/charts/icm-as/Chart.yaml
index 61e699dc..a49069d9 100644
--- a/charts/icm-as/Chart.yaml
+++ b/charts/icm-as/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 # name and version must be in this exact order, otherwise bump2version won't work
 name: icm-as
-version: 2.4.1
+version: 2.5.0
 description: Intershop Commerce Management - AppServer
 type: application
 appVersion: 11.10.3-LTS
diff --git a/charts/icm-replication/.bumpversion.toml b/charts/icm-replication/.bumpversion.toml
index 999434fd..5a7fd761 100644
--- a/charts/icm-replication/.bumpversion.toml
+++ b/charts/icm-replication/.bumpversion.toml
@@ -1,5 +1,5 @@
 [tool.bumpversion]
-current_version = "2.9.1"
+current_version = "2.10.0"
 
 [[tool.bumpversion.files]]
 filename = "Chart.yaml"
diff --git a/charts/icm-replication/Chart.yaml b/charts/icm-replication/Chart.yaml
index 525f9a99..8e0623af 100644
--- a/charts/icm-replication/Chart.yaml
+++ b/charts/icm-replication/Chart.yaml
@@ -3,16 +3,16 @@ appVersion: "11.9.0"
 description: Intershop Commerce Management - ICM Replication
 # name and version must be in this exact order, otherwise bump2version won't work
 name: icm-replication
-version: 2.9.1
+version: 2.10.0
 annotations:
   requestedMemoryQuota: 9Gi
   requestedCpuQuotaInMinutes: 3000
 dependencies:
   - name: icm
-    version: 2.9.1
+    version: 2.10.0
     repository: file://../icm
     alias: icm-live
   - name: icm
-    version: 2.9.1
+    version: 2.10.0
     repository: file://../icm
     alias: icm-edit
diff --git a/charts/icm/.bumpversion.toml b/charts/icm/.bumpversion.toml
index ad8bc1e1..2a048ae8 100644
--- a/charts/icm/.bumpversion.toml
+++ b/charts/icm/.bumpversion.toml
@@ -1,5 +1,5 @@
 [tool.bumpversion]
-current_version = "2.9.1"
+current_version = "2.10.0"
 
 [[tool.bumpversion.files]]
 filename = "Chart.yaml"
diff --git a/charts/icm/Chart.yaml b/charts/icm/Chart.yaml
index 947309f1..f1837711 100644
--- a/charts/icm/Chart.yaml
+++ b/charts/icm/Chart.yaml
@@ -3,14 +3,14 @@ appVersion: "12.0.0"
 description: Intershop Commerce Management - ICM
 # name and version must be in this exact order, otherwise bump2version won't work
 name: icm
-version: 2.9.1
+version: 2.10.0
 # test related annotations
 annotations:
   requestedMemoryQuota: 6000Mi
   requestedCpuQuotaInMinutes: "2200"
 dependencies:
   - name: icm-as
-    version: 2.4.1
+    version: 2.5.0
     repository: file://../icm-as
   - name: icm-web
     version: 0.13.2

From 9ef82faa5f9c00fe4e60c16fed3d512d79d3e696 Mon Sep 17 00:00:00 2001
From: khauser <khauser@users.noreply.github.com>
Date: Tue, 7 Jan 2025 16:31:15 +0000
Subject: [PATCH 3/3] chore: generated changelog+release notes for icm-as:minor

---
 charts/icm-as/CHANGELOG.md     | 15 +++++++++++++++
 charts/icm-as/RELEASE_NOTES.md | 11 +++++------
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/charts/icm-as/CHANGELOG.md b/charts/icm-as/CHANGELOG.md
index fba2bb8b..06267dff 100644
--- a/charts/icm-as/CHANGELOG.md
+++ b/charts/icm-as/CHANGELOG.md
@@ -1,4 +1,18 @@
 
+<a name="icm-as-2.5.0"></a>
+## [icm-as-2.5.0](https://github.com/intershop/helm-charts/compare/icm-as-2.4.1...icm-as-2.5.0)
+
+> 2025-01-07
+
+### Chore
+
+* bump versions of icm-as:minor
+
+### Feat
+
+* **icm:** jgroups location directory configurable ([#865](https://github.com/intershop/helm-charts/issues/865))
+
+
 <a name="icm-as-2.4.1"></a>
 ## [icm-as-2.4.1](https://github.com/intershop/helm-charts/compare/icm-as-2.4.0...icm-as-2.4.1)
 
@@ -6,6 +20,7 @@
 
 ### Chore
 
+* generated changelog+release notes for icm-as:patch
 * bump versions of icm-as:patch
 
 ### Fix
diff --git a/charts/icm-as/RELEASE_NOTES.md b/charts/icm-as/RELEASE_NOTES.md
index 9ef9d7da..4f59d563 100644
--- a/charts/icm-as/RELEASE_NOTES.md
+++ b/charts/icm-as/RELEASE_NOTES.md
@@ -1,15 +1,14 @@
 
-<a name="icm-as-2.4.1"></a>
-## [icm-as-2.4.1](https://github.com/intershop/helm-charts/compare/icm-as-2.4.0...icm-as-2.4.1)
+<a name="icm-as-2.5.0"></a>
+## [icm-as-2.5.0](https://github.com/intershop/helm-charts/compare/icm-as-2.4.1...icm-as-2.5.0)
 
 > 2025-01-07
 
 ### Chore
 
-* bump versions of icm-as:patch
+* bump versions of icm-as:minor
 
-### Fix
+### Feat
 
-* **icm:** use newer mssql image ([#871](https://github.com/intershop/helm-charts/issues/871))
-* **icm:** update kpi exporter schedule date ([#102730](https://github.com/intershop/helm-charts/issues/102730))
+* **icm:** jgroups location directory configurable ([#865](https://github.com/intershop/helm-charts/issues/865))