feat: automatically add public key for Fynbos wallets #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screencast.from.03-10-24.08.15.41.PM.IST.webm |
github-actions
bot
added
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
|
Fynbos is looking to remove Cloudflare Access OTP wall from EU1 server. Will wait for that and add E2E tests. |
github-actions
bot
added
area: documentation
There was a problem hiding this comment.
Had a glimpse at the PR - not fully reviewed.
Let me know what is your opinion on this approach. Instead of navigating through the DOM, we can just make two fetch calls to upload the key - #649.
(Ignore comments - the main change is in keyAutoAdd/fynbos.ts)
* Proposal for Fynbos automatic key add * Remove comment from OP service * Cleanup * address feedback --------- Co-authored-by: Sid Vishnoi <[email protected]>
This was referenced Oct 10, 2024
raducristianpopa
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request