-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to specify destination expiry duration #57
Comments
@MatthewPhinney I think you ran into this as well |
I did indeed. Thanks for creating the issue. |
@sentientwaffle will this be addressed by your changes to getQuote in connector? |
also should include source expiry |
Source expiry in universal mode is a function of the destination expiry + On Sat, Apr 16, 2016 at 12:37 AM, yana-novikova [email protected]
Evan Schwartz | Software Architect | Ripple |
@emschwartz in atomic mode the notary's Case should have an expiry, but not the transfers. |
We want to be able to set source or destination expiry on the getQuote because we use expiry value that gets returned from getQuote for setting expiry on the notary case. |
@yana-novikova I'm not sure I understand that. If you're determining the expiry in the first place, why not just pass that to the notary instead of passing the value returned from getQuote? |
The current RC-ILP flow is:
One option is to call the connector's Since the connector should be able to handle setting an expiry duration on a quote, it seems like updating the connector to support this would be a better option. A third approach would be to have RC set up the notary case directly, so that we could completely ignore the transfer expiries. I'd be fine with this approach, but I'd have to run it by the RC team. Even if we took this approach, I think we'd want to change the connector to allow a user to specify the transfer expiry as a query param. |
The sender already handles turning the I'm not sure I understand the options involving changing the connector or ignoring the expiries (wouldn't the latter mean that the expiries are put in anyway and the transfers expire even when you don't want them to?) |
We only care about the case expiry. But the only way we can change it, is by changing the Changing the connector's |
any update on this? |
Well, interledgerjs/ilp-connector#150 fixes the issue @MatthewPhinney references ( |
Right now the expiry durations are set automatically. The user of this library should be able to specify how long they expect the recipient to take to fulfill the condition
The text was updated successfully, but these errors were encountered: