Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a small dashboard display issue #1658

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

mafux777
Copy link
Contributor

Interbtc UI Pull Request Template

Description

Dashboard was crashing when certain data not available

To fix this, I added a question mark marking the variable as possibly undefined

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Apr 5, 2024 0:40am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 0:40am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Apr 5, 2024 0:40am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 0:40am

Copy link

Running Lighthouse audit...

@spazcoin
Copy link

I looked at the unit test failures with @mafux777 today and don't see a relation between the failure and the change he submitted. I'm guessing the unit test failures are a package dependency instead.

@tomjeatt tomjeatt merged commit 18da743 into interlay:master Jun 24, 2024
6 of 8 checks passed
@tomjeatt
Copy link
Collaborator

Merged—thanks for fixing! You're right, there are no unit test failures related to this PR but I appreciate you checking.

tomjeatt added a commit that referenced this pull request Jul 9, 2024
* master: (241 commits)
  chore: release v2.41.13
  chore: bump bridge and add new dependency (#1664)
  Fixed a small dashboard display issue (#1658)
  chore: release v2.41.12
  api: improve cache-control headers (#1659)
  chore: release v2.41.11
  chore: release v2.41.10
  HDX and BNC icons (#1655)
  api: add Vercel KV cache for storing market data (#1654)
  Tom/bridge 0.5.1 (#1651)
  chore: release v2.41.9
  chore: bump bridge (#1648)
  chore: release v2.41.8
  hotfix: XCM polkadot/kintsugi max transferable balance (#1645)
  Revert "[release] Interlay 2.41.7 (#1639)" (#1641)
  [release] Interlay 2.41.7 (#1639)
  chore: release v2.41.7
  fix: chart counter enum and lower value for collateral (#1638)
  chore: release v2.41.6
  refactor: line chart config (#1635)
  ...

# Conflicts:
#	package.json
#	src/services/fetchers/cumulative-vault-collateral-volumes-fetcher.ts
#	yarn.lock
tomjeatt added a commit that referenced this pull request Jul 9, 2024
* master: (241 commits)
  chore: release v2.41.13
  chore: bump bridge and add new dependency (#1664)
  Fixed a small dashboard display issue (#1658)
  chore: release v2.41.12
  api: improve cache-control headers (#1659)
  chore: release v2.41.11
  chore: release v2.41.10
  HDX and BNC icons (#1655)
  api: add Vercel KV cache for storing market data (#1654)
  Tom/bridge 0.5.1 (#1651)
  chore: release v2.41.9
  chore: bump bridge (#1648)
  chore: release v2.41.8
  hotfix: XCM polkadot/kintsugi max transferable balance (#1645)
  Revert "[release] Interlay 2.41.7 (#1639)" (#1641)
  [release] Interlay 2.41.7 (#1639)
  chore: release v2.41.7
  fix: chart counter enum and lower value for collateral (#1638)
  chore: release v2.41.6
  refactor: line chart config (#1635)
  ...

# Conflicts:
#	package.json
#	src/services/fetchers/cumulative-vault-collateral-volumes-fetcher.ts
#	yarn.lock
tomjeatt added a commit that referenced this pull request Oct 9, 2024
* master: (246 commits)
  chore: release v2.41.14
  chore: update XCM nodes (#1672)
  Cherry pick: api: add phala-network to the pricefeed (#1668) (#1670)
  chore: Update xcm-endpoints.ts (#1669)
  exclude USDC.wh from foreign assets (#1643)
  chore: release v2.41.13
  chore: bump bridge and add new dependency (#1664)
  Fixed a small dashboard display issue (#1658)
  chore: release v2.41.12
  api: improve cache-control headers (#1659)
  chore: release v2.41.11
  chore: release v2.41.10
  HDX and BNC icons (#1655)
  api: add Vercel KV cache for storing market data (#1654)
  Tom/bridge 0.5.1 (#1651)
  chore: release v2.41.9
  chore: bump bridge (#1648)
  chore: release v2.41.8
  hotfix: XCM polkadot/kintsugi max transferable balance (#1645)
  Revert "[release] Interlay 2.41.7 (#1639)" (#1641)
  ...

# Conflicts:
#	api/market_data.js
#	package.json
#	src/hooks/api/use-get-currencies.tsx
#	src/hooks/api/xcm/xcm-endpoints.ts
#	yarn.lock
tomjeatt added a commit that referenced this pull request Oct 9, 2024
* master: (246 commits)
  chore: release v2.41.14
  chore: update XCM nodes (#1672)
  Cherry pick: api: add phala-network to the pricefeed (#1668) (#1670)
  chore: Update xcm-endpoints.ts (#1669)
  exclude USDC.wh from foreign assets (#1643)
  chore: release v2.41.13
  chore: bump bridge and add new dependency (#1664)
  Fixed a small dashboard display issue (#1658)
  chore: release v2.41.12
  api: improve cache-control headers (#1659)
  chore: release v2.41.11
  chore: release v2.41.10
  HDX and BNC icons (#1655)
  api: add Vercel KV cache for storing market data (#1654)
  Tom/bridge 0.5.1 (#1651)
  chore: release v2.41.9
  chore: bump bridge (#1648)
  chore: release v2.41.8
  hotfix: XCM polkadot/kintsugi max transferable balance (#1645)
  Revert "[release] Interlay 2.41.7 (#1639)" (#1641)
  ...

# Conflicts:
#	package.json
#	src/hooks/api/use-get-currencies.tsx
#	src/hooks/api/xcm/xcm-endpoints.ts
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants