Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global warning banner #1551

Closed
tomjeatt opened this issue Sep 1, 2023 · 1 comment · Fixed by #1552
Closed

Global warning banner #1551

tomjeatt opened this issue Sep 1, 2023 · 1 comment · Fixed by #1552
Assignees

Comments

@tomjeatt
Copy link
Collaborator

tomjeatt commented Sep 1, 2023

Add a permanent global warning banner, to replace the banner that was merged here:
#1550

  1. Should be feature flagged so that it can be toggled per environment
  2. Content should be handled as an env variable so that it can be shown without a hotfix, and so that content can be managed per environment.

This will be a permanent change, i.e. the GlobalWarningBanner will remain in app.tsx.

@danielsimao might be possible to combine it with #1549 although if getting the global status is tricky or time consuming then we'll handle them as separate tasks:

@nud3l nud3l added this to Backlog Sep 1, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Sep 1, 2023
@tomjeatt tomjeatt self-assigned this Sep 4, 2023
@tomjeatt
Copy link
Collaborator Author

tomjeatt commented Sep 4, 2023

Agreed requirements with Jay:

  1. One env variable for content. If this is set, banner will be shown.
  2. Optional env variable for a link. This will be generic, i.e. if set then a 'More information' text link appended to the content.
  3. Placement and width styles will follow the same pattern as the welcome banner.

No design required, but will look approximately like this:

Screenshot 2023-09-04 at 10 09 25

@github-project-automation github-project-automation bot moved this from New 🆕 to Done ✅ in Backlog Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant