Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger tests linter issue #271

Open
ppalucki opened this issue Jul 11, 2024 · 1 comment
Open

Fix logger tests linter issue #271

ppalucki opened this issue Jul 11, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ppalucki
Copy link
Contributor 

golangci-lint run
pkg/controller/lifecycle/add_test.go:42:9: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
                log = klogr.New()

klog with buffer is required for proper unit test checks (cannot be simply replaced by textlogger
@ppalucki ppalucki added enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2024
@yashathwani
Copy link

Can i work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppalucki @yashathwani