Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request > ability to use github unique ID for github_membership #524

Open
2-X opened this issue Jul 27, 2020 · 4 comments · May be fixed by #2422
Open

Feature Request > ability to use github unique ID for github_membership #524

2-X opened this issue Jul 27, 2020 · 4 comments · May be fixed by #2422
Labels
r/team_membership Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@2-X
Copy link

2-X commented Jul 27, 2020

Currently we can only provide a username to in the github_membership and github_user data sources. We're interested in using the unique identifier found at https://api.github.com/users/{USERNAME} in the "id" field. This is because username can be changed by the user, which causes our terraform scripts for github memberships to be out of date. The id cannot be changed and is globally unique, which makes it a much better candidate.

Instead of providing the username to the /users endpoint, you can get the same information by providing the id to the /user endpoint (e.g. https://api.github.com/user/{id}).
@jcudit jcudit added Type: Feature New feature or request r/team_membership labels Nov 26, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 8, 2022
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone Priority: Normal labels Dec 8, 2022
@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 9, 2022
@mynameistechno
Copy link

Yeah this would be nifty ..

@kfcampbell kfcampbell moved this to 🔥 Backlog in 🧰 Octokit Active Oct 20, 2023
@github-actions GitHub Actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jul 15, 2024
@2-X
Copy link
Author

2-X commented Jul 15, 2024

yeah i would still love this though...

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Jul 16, 2024
@jbuck jbuck linked a pull request Oct 13, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
r/team_membership Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(data_github_user): Add lookup by id jbuck/terraform-provider-github
5 participants
@nickfloyd @mynameistechno @jcudit @kfcampbell @2-X