Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Support GitHub repository custom properties #1956

Open
1 task done
yu-iskw opened this issue Oct 13, 2023 · 19 comments · May be fixed by #2107 or #2316
Open
1 task done

[FEAT]: Support GitHub repository custom properties #1956

yu-iskw opened this issue Oct 13, 2023 · 19 comments · May be fixed by #2107 or #2316
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request

Comments

@yu-iskw
Copy link

yu-iskw commented Oct 13, 2023

Describe the need

GitHub just announced the feature of GitHub repository custom properties. We can use the information of custom properties to apply rules to repository in GitHub organization(s). It would be good to support the feature in the terraform provider as well. By doing that, we will be able to manage custom properties and rule sets in terraform.

https://github.blog/changelog/2023-10-12-github-repository-custom-properties-beta/

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@yu-iskw yu-iskw added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Oct 13, 2023
@kfcampbell
Copy link
Member

Unfortunately, this feature is not released on the API yet. Once support is added in the API, we can implement it in the provider.

@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Oct 16, 2023
@kfcampbell kfcampbell moved this from 🔥 Backlog to 🛑 Blocked/Awaiting Response in 🧰 Octokit Active Oct 16, 2023
@kfcampbell kfcampbell added Status: Blocked Some technical or requirement is blocking the issue and removed Status: Triage This is being looked at and prioritized labels Oct 16, 2023
@usmonster
Copy link
Contributor

Looks like a REST API is in public beta now. Is that enough to get started? Thanks!

@kfcampbell
Copy link
Member

Ideally there would be more than just a GET. We could make a data source with the existing endpoint, but not a full resource.

@laughedelic
Copy link
Contributor

There are more endpoints here (incl. creation): https://docs.github.com/en/rest/orgs/custom-properties?apiVersion=2022-11-28

@kfcampbell
Copy link
Member

Ahh my mistake, thanks for correcting me!

@roeishuster
Copy link

roeishuster commented Dec 13, 2023

Hey, do you guys plan on adding this in an upcoming provider update?

@kfcampbell
Copy link
Member

GitHub's SDK team unfortunately does not have the bandwidth to take this on ourselves, though we're very receptive of PRs!

@alileza alileza linked a pull request Jan 16, 2024 that will close this issue
4 tasks
@alileza
Copy link
Contributor

alileza commented Jan 17, 2024

@kfcampbell I'll make an attempt to PR soon, just drafted init. But I might just found some blockers of GitHub API didn't respond custom property id, because on resource update I got an error of expected numerical ID. strconv.ParseInt: parsing, but no ID on the api.

If you can give a bit of hint, on the draft PR I have, that would be superb

@nayuta
Copy link

nayuta commented Mar 7, 2024

Hi, I also need to support custom properties for repositories. However, it needs to update go-github. So, I created the issue: #2187

@nnellanspdl
Copy link

This would be a welcome addition.

@kfcampbell
Copy link
Member

It's worth noting that we (GitHub's SDK team) are working on a Go SDK generated from GitHub's OpenAPI specification. It includes all routes published in the GitHub API, so coverage doesn't need to be added manually. I've been looking for an excuse to add it to the project; this could be it.

@Simon-Boyer
Copy link

I have a client that will need this very soon. If I can help fast-track this by contributing I can put some hours in this. I see there is already a PR opened and some discussions around the Go SDK, is there anything I can do here?

@connor-miller-kr
Copy link

Any update on this feature?

@Simon-Boyer
Copy link

Any update on this feature?

I wouldnt mind contributing for this feature as soon as the go-github client is bumped to v60. But that PR looks a bit stuck...

@larmitage-bjss
Copy link

Now the go-github PR has been merged is there potential for any progress on this feature soon? Thanks!

@felixlut
Copy link
Contributor

felixlut commented Jul 15, 2024

#2107 only pertains to the Organization level custom properties (and looks a bit stale), while the ditto on the repository level hasn't been worked on from what I can tell. I've started working on it in #2316 but gotten stuck due to each available SDK lacking in functionality in regards to repository custom properties:

Once I see some progress in either of those areas I'll revisit that PR

@Hulidex
Copy link

Hulidex commented Nov 14, 2024

Any update so far? Thank you!!

@felixlut
Copy link
Contributor

#2316 is blocked by #2443

@philthethrill99
Copy link

#2316 is blocked by #2443

Now that #2443 is merged, do you have an ETA on this feature request?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request
Projects
None yet