-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: Support GitHub repository custom properties #1956
Comments
Unfortunately, this feature is not released on the API yet. Once support is added in the API, we can implement it in the provider. |
Looks like a REST API is in public beta now. Is that enough to get started? Thanks! |
Ideally there would be more than just a GET. We could make a data source with the existing endpoint, but not a full resource. |
There are more endpoints here (incl. creation): https://docs.github.com/en/rest/orgs/custom-properties?apiVersion=2022-11-28 |
Ahh my mistake, thanks for correcting me! |
Hey, do you guys plan on adding this in an upcoming provider update? |
GitHub's SDK team unfortunately does not have the bandwidth to take this on ourselves, though we're very receptive of PRs! |
@kfcampbell I'll make an attempt to PR soon, just drafted init. But I might just found some blockers of GitHub API didn't respond custom property id, because on resource update I got an error of If you can give a bit of hint, on the draft PR I have, that would be superb |
Hi, I also need to support custom properties for repositories. However, it needs to update go-github. So, I created the issue: #2187 |
This would be a welcome addition. |
It's worth noting that we (GitHub's SDK team) are working on a Go SDK generated from GitHub's OpenAPI specification. It includes all routes published in the GitHub API, so coverage doesn't need to be added manually. I've been looking for an excuse to add it to the project; this could be it. |
I have a client that will need this very soon. If I can help fast-track this by contributing I can put some hours in this. I see there is already a PR opened and some discussions around the Go SDK, is there anything I can do here? |
Any update on this feature? |
I wouldnt mind contributing for this feature as soon as the go-github client is bumped to v60. But that PR looks a bit stuck... |
Now the go-github PR has been merged is there potential for any progress on this feature soon? Thanks! |
#2107 only pertains to the Organization level custom properties (and looks a bit stale), while the ditto on the repository level hasn't been worked on from what I can tell. I've started working on it in #2316 but gotten stuck due to each available SDK lacking in functionality in regards to repository custom properties:
Once I see some progress in either of those areas I'll revisit that PR |
Any update so far? Thank you!! |
Describe the need
GitHub just announced the feature of GitHub repository custom properties. We can use the information of custom properties to apply rules to repository in GitHub organization(s). It would be good to support the feature in the terraform provider as well. By doing that, we will be able to manage custom properties and rule sets in terraform.
https://github.blog/changelog/2023-10-12-github-repository-custom-properties-beta/
SDK Version
No response
API Version
No response
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: