Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error-checking into AbstractInstrument #17

Open
3 tasks
cgranade opened this issue Aug 7, 2013 · 0 comments
Open
3 tasks

Move error-checking into AbstractInstrument #17

cgranade opened this issue Aug 7, 2013 · 0 comments
Milestone

Comments

@cgranade
Copy link
Contributor

cgranade commented Aug 7, 2013

Several instrument classes, such as NewportESP301 and SRSCTC100 support checking for instrument errors after each sendcmd(), but this could be consolidated into a base class by making a new base class method called _errcheck(). By default, this method would always succeed without error, but could be overridden by specific instrument classes to quickly enable adding robust error checking when available.

  • Create AbstractInstrument._errcheck().
  • Modify AbstractInstrument.sendcmd() and AbstractInstrument.query() to accept errcheck kwarg.
  • Consolidate existing error-checking logic in instrument derived classes.
@cgranade cgranade added this to the 1.0 milestone Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant