Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absl intrinsics #135

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Fix absl intrinsics #135

merged 3 commits into from
Nov 29, 2024

Conversation

alexlapa
Copy link
Collaborator

Error:

  cargo:warning=/libwebrtc-sys/lib/x86_64-unknown-linux-gnu/include/third_party/abseil-cpp/absl/numeric/int128.h:1182:10: fatal error: absl/numeric/int128_have_intrinsic.inc: No such file or directory
  cargo:warning= 1182 | #include "absl/numeric/int128_have_intrinsic.inc"  // IWYU pragma: export
  cargo:warning=      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=compilation terminated.

So we need to keep .inc files in include dir.

@alexlapa
Copy link
Collaborator Author

FCM

Keep .inc files in include directory (#135)

@alexlapa alexlapa self-assigned this Nov 29, 2024
@alexlapa alexlapa requested a review from evdokimovs November 29, 2024 10:51
@alexlapa alexlapa added enhancement New feature or request k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Nov 29, 2024
@evdokimovs evdokimovs marked this pull request as ready for review November 29, 2024 14:02
@evdokimovs evdokimovs requested a review from tyranron November 29, 2024 14:02
@tyranron tyranron added k::toolchain Applies to changes of project toolchain and removed k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Nov 29, 2024
@tyranron tyranron enabled auto-merge (squash) November 29, 2024 16:50
@tyranron tyranron merged commit ac2ddee into main Nov 29, 2024
12 checks passed
@tyranron tyranron deleted the fix-absl-intrinsics branch November 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evdokimovs evdokimovs evdokimovs approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement New feature or request k::toolchain Applies to changes of project toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlapa @tyranron @evdokimovs