gaudi support training #330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JamesKunstle
commented
Nov 12, 2024
JamesKunstle
commented
- reorg main function; add 'hpu' option w/o implementation
- implement training for HPU
|
Builds on changes from #329. Still needs to be tested. |
This was
linked to
issues
Nov 12, 2024
JamesKunstle
force-pushed
the
gaudi-support-training
branch
from
c79c2e1 to
f9192d1
Compare
The `main` training function needed to be broken down into smaller functions for readability/testability. WORLD_SIZE, LOCAL_RANK, and RANK have also been extracted and made global constants since they are set by the administrating multiprocessing launcher (torchrun, in our case). HPU configuration options and checks are also added. Signed-off-by: James Kunstle <[email protected]>
HPU cards (Gaudi 2 and 3) can't use Accelerate code path. This contribution adds the training setup and loop for FSDP-only training. Minor modifications required for HPUs specifically. Signed-off-by: James Kunstle <[email protected]>
JamesKunstle
force-pushed
the
gaudi-support-training
branch
from
f9192d1 to
aa192e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.